Refresh HiveGrid Cloud reference snapshot

This commit is contained in:
david committed 2026-08-03 15:31:14 +02:00
1 parent 5e99e14772
commit 7f88026f79
5955 files changed
+1177325 -188362

No files matched your search

@@ -12,30 +12,27 @@
// preloaded into the editor (same audited createWorkspaceRole path).
import { useEffect, useMemo, useState } from "react";
import { Link } from "react-router";
import { useTranslation } from "react-i18next";
import * as SubframeCore from "@subframe/core";
import { FeatherCopy, FeatherEdit2, FeatherMoreHorizontal, FeatherPlus, FeatherTrash } from "@subframe/core";
import { FeatherCopy, FeatherEdit2, FeatherMoreHorizontal, FeatherPlus, FeatherShield, FeatherTrash, FeatherUserCheck } from "@subframe/core";
import type { RoleEditorInputPermission, RolesListRow, RolesListVM, RoleTypeKey } from "@hivegrid/view-models";
import { buildRoleEditorVM, filterRoleEditorSections, togglePermission, EMPTY_ROLES_FILTER, filterRolesRows, type RolesListFilterState } from "@hivegrid/view-models";
import { permissionDisplayDescription, permissionDisplayName, roleDisplayDescription, roleDisplayName } from "~/components/core/roles/roleDisplay";
import { FacetFilterBar, type ClientFacet } from "../shared/FacetFilterBar";
import { PageIntro } from "../shared/PageShell";
import { useLocaleFormatters } from "~/locale/format";
import { Alert } from "~/ui/components/Alert";
import { Button } from "~/ui/components/Button";
import { Dialog } from "~/ui/components/Dialog";
import { FormDialog } from "../shared/FormDialog";
import { DropdownMenu } from "~/ui/components/DropdownMenu";
import { EmptyState } from "~/ui/components/EmptyState";
import { IconButton } from "~/ui/components/IconButton";
import { SearchInput } from "~/ui/components/SearchInput";
import { Select } from "~/ui/components/Select";
import { Switch } from "~/ui/components/Switch";
import { Table } from "~/ui/components/Table";
import { Tabs } from "~/ui/components/Tabs";
import { TextArea } from "~/ui/components/TextArea";
import { TextInput } from "~/ui/components/TextInput";
const FILTER_ALL = "__all__";
export type RoleMutationInput = { name: string; description: string; permissionNames: string[] };
export type RolesActions = {
@@ -54,7 +51,6 @@ export type RolesPageProps = {
/** roleId → assigned permission names (editor prefill + M04B duplication). */
rolePermissionNames: Readonly<Record<string, readonly string[]>>;
/** Tab bar back to S01 (members). */
membersTabHref: string;
actions: RolesActions;
submitting: boolean;
errorMessage: string | null;
@@ -74,7 +70,7 @@ type EditorState = {
enabled: ReadonlySet<string>;
};
export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHref, actions, submitting, errorMessage, closeSignal }: RolesPageProps) {
export function RolesPage({ vm, editorCatalog, rolePermissionNames, actions, submitting, errorMessage, closeSignal }: RolesPageProps) {
const { t } = useTranslation();
const formatters = useLocaleFormatters();
const [filter, setFilter] = useState<RolesListFilterState>(EMPTY_ROLES_FILTER);
@@ -97,6 +93,42 @@ export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHr
const data = vm.data;
const rows = filterRolesRows(data.rows, filter);
const facets: ClientFacet[] = [
{
key: "type",
label: t("settings.rolesAndPermissions.columns.type"),
icon: <FeatherShield />,
tone: "violet-subtle",
options: [
{ value: "system", label: t("settings.rolesAndPermissions.type.system") },
{ value: "custom", label: t("settings.rolesAndPermissions.type.custom") },
],
selected: new Set(filter.type ? [filter.type] : []),
},
{
key: "inUse",
label: t("settings.rolesAndPermissions.filters.inUse"),
icon: <FeatherUserCheck />,
tone: "blue-subtle",
options: [
{ value: "yes", label: t("settings.rolesAndPermissions.filters.inUseYes") },
{ value: "no", label: t("settings.rolesAndPermissions.filters.inUseNo") },
],
selected: new Set(filter.inUse === null ? [] : [filter.inUse ? "yes" : "no"]),
},
];
function toggleFacet(facetKey: string, value: string) {
if (facetKey === "type") {
return setFilter((prev) => ({ ...prev, type: prev.type === value ? null : (value as RoleTypeKey) }));
}
if (facetKey === "inUse") {
const next = value === "yes";
return setFilter((prev) => ({ ...prev, inUse: prev.inUse === next ? null : next }));
}
return undefined;
}
function openEditorFor(row: RolesListRow) {
setEditor({
roleId: row.id,
@@ -120,14 +152,14 @@ export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHr
return (
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.rolesAndPermissions.roles">
{/* Header: title + subtitle (0px rhythm) + create CTA (M04A) */}
<div className="flex flex-wrap items-start justify-between gap-4">
<div className="flex flex-col gap-0">
<span className="text-heading-2 font-heading-2 text-text-neutral-primary">{t("settings.members.tabs.rolesAndPermissions")}</span>
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
{t("settings.rolesAndPermissions.subtitle")}
</span>
</div>
{/* The page header (title + subtitle) is rendered by the route above the layout, like Mitglieder. */}
{/* AK-SET-01: the Team-Hub renders the tab bar this screen used to carry. */}
{/* Intro + create CTA on one row, exactly as the Mitglieder tab next door
hosts its own; the hub header above carries only title and subtitle. */}
<div className="mobile:flex-col mobile:items-start flex w-full items-start justify-between gap-4">
<PageIntro uiId="ui.settings.rolesAndPermissions.intro">{t("settings.rolesAndPermissions.subtitle")}</PageIntro>
{data.canCreate ? (
<Button
icon={<FeatherPlus />}
@@ -139,46 +171,23 @@ export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHr
) : null}
</div>
{/* Tabs: Mitarbeiter | Rollen und Berechtigungen (shared with S01) */}
<Tabs>
<Link to={membersTabHref} className="contents no-underline" data-ui-id="ui.settings.rolesAndPermissions.tab.members">
<Tabs.Item>{t("settings.members.tabs.members")}</Tabs.Item>
</Link>
<Tabs.Item active>{t("settings.members.tabs.rolesAndPermissions")}</Tabs.Item>
</Tabs>
{/* Toolbar: search (name/description) + type/in-use filters */}
<div className="flex flex-wrap items-end gap-4" data-ui-id="ui.settings.rolesAndPermissions.roles.filter">
<SearchInput
className="max-w-[320px]"
placeholder={t("settings.rolesAndPermissions.filters.searchPlaceholder")}
hideShortcut
value={filter.query}
onChange={(event) => setFilter((prev) => ({ ...prev, query: event.target.value }))}
/>
<Select
className="max-w-[200px]"
label={t("settings.rolesAndPermissions.columns.type")}
showLabel
value={filter.type ?? FILTER_ALL}
onValueChange={(value: string) => setFilter((prev) => ({ ...prev, type: value === FILTER_ALL ? null : (value as RoleTypeKey) }))}
>
<Select.Item value={FILTER_ALL}>{t("settings.members.filters.all")}</Select.Item>
<Select.Item value="system">{t("settings.rolesAndPermissions.type.system")}</Select.Item>
<Select.Item value="custom">{t("settings.rolesAndPermissions.type.custom")}</Select.Item>
</Select>
<Select
className="max-w-[200px]"
label={t("settings.rolesAndPermissions.filters.inUse")}
showLabel
value={filter.inUse === null ? FILTER_ALL : filter.inUse ? "yes" : "no"}
onValueChange={(value: string) => setFilter((prev) => ({ ...prev, inUse: value === FILTER_ALL ? null : value === "yes" }))}
>
<Select.Item value={FILTER_ALL}>{t("settings.members.filters.all")}</Select.Item>
<Select.Item value="yes">{t("settings.rolesAndPermissions.filters.inUseYes")}</Select.Item>
<Select.Item value="no">{t("settings.rolesAndPermissions.filters.inUseNo")}</Select.Item>
</Select>
</div>
{/* --- Filter bar: the shared facet strip the sibling tabs and the board
lists wear - free-text box, facet buttons, chips for what is active
and one reset. Both facets are single-select, so picking the active
option again clears it, just as the chip's X does. --- */}
<FacetFilterBar
uiId="ui.settings.rolesAndPermissions.roles.filter"
facets={facets}
onToggle={toggleFacet}
search={filter.query}
onSearchChange={(value) => setFilter((prev) => ({ ...prev, query: value }))}
searchPlaceholder={t("settings.rolesAndPermissions.filters.searchPlaceholder")}
onReset={() => setFilter(EMPTY_ROLES_FILTER)}
labels={{
reset: t("settings.rolesAndPermissions.filters.reset"),
removeChip: t("settings.rolesAndPermissions.filters.removeChip"),
}}
/>
{data.rows.length === 0 ? (
<div data-ui-id="ui.settings.rolesAndPermissions.roles.empty">
@@ -225,46 +234,50 @@ export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHr
{t("models.permission.count", { count: row.permissionCount, formattedCount: formatters.number(row.permissionCount) })}
</span>
</Table.Cell>
<Table.Cell>
<div className="flex grow shrink-0 basis-0 items-center justify-end">
{row.canEdit || row.canDuplicate || row.canDelete ? (
<SubframeCore.DropdownMenu.Root>
<SubframeCore.DropdownMenu.Trigger asChild>
<IconButton icon={<FeatherMoreHorizontal />} data-ui-id="ui.settings.rolesAndPermissions.roles.rowActions" />
</SubframeCore.DropdownMenu.Trigger>
<SubframeCore.DropdownMenu.Portal>
<SubframeCore.DropdownMenu.Content side="bottom" align="end" sideOffset={4} asChild>
<DropdownMenu>
{row.canEdit ? (
<DropdownMenu.DropdownItem icon={<FeatherEdit2 />} onClick={() => openEditorFor(row)}>
{t("shared.edit")}
</DropdownMenu.DropdownItem>
) : null}
{row.canDuplicate ? (
<DropdownMenu.DropdownItem
icon={<FeatherCopy />}
onClick={() =>
setBasics({
source: row,
name: t("settings.rolesAndPermissions.duplicate.copyName", { name: row.name }),
description: row.description,
})
}
>
{t("settings.rolesAndPermissions.duplicate.action")}
</DropdownMenu.DropdownItem>
) : null}
{row.canDelete ? (
<DropdownMenu.DropdownItem icon={<FeatherTrash />} onClick={() => setDeleteRow(row)}>
{t("shared.delete")}
</DropdownMenu.DropdownItem>
) : null}
</DropdownMenu>
</SubframeCore.DropdownMenu.Content>
</SubframeCore.DropdownMenu.Portal>
</SubframeCore.DropdownMenu.Root>
) : null}
</div>
<Table.Cell variant="align-right">
{row.canEdit || row.canDuplicate || row.canDelete ? (
<SubframeCore.DropdownMenu.Root>
<SubframeCore.DropdownMenu.Trigger asChild>
<IconButton
variant="ghost"
size="small"
icon={<FeatherMoreHorizontal />}
aria-label={`${t("shared.actions")}: ${roleDisplayName({ name: row.name, description: row.description }, t)}`}
data-ui-id="ui.settings.rolesAndPermissions.roles.rowActions"
/>
</SubframeCore.DropdownMenu.Trigger>
<SubframeCore.DropdownMenu.Portal>
<SubframeCore.DropdownMenu.Content side="bottom" align="end" sideOffset={4} asChild>
<DropdownMenu>
{row.canEdit ? (
<DropdownMenu.DropdownItem icon={<FeatherEdit2 />} onClick={() => openEditorFor(row)}>
{t("shared.edit")}
</DropdownMenu.DropdownItem>
) : null}
{row.canDuplicate ? (
<DropdownMenu.DropdownItem
icon={<FeatherCopy />}
onClick={() =>
setBasics({
source: row,
name: t("settings.rolesAndPermissions.duplicate.copyName", { name: row.name }),
description: row.description,
})
}
>
{t("settings.rolesAndPermissions.duplicate.action")}
</DropdownMenu.DropdownItem>
) : null}
{row.canDelete ? (
<DropdownMenu.DropdownItem icon={<FeatherTrash />} onClick={() => setDeleteRow(row)}>
{t("shared.delete")}
</DropdownMenu.DropdownItem>
) : null}
</DropdownMenu>
</SubframeCore.DropdownMenu.Content>
</SubframeCore.DropdownMenu.Portal>
</SubframeCore.DropdownMenu.Root>
) : null}
</Table.Cell>
</Table.Row>
))}
@@ -278,71 +291,61 @@ export function RolesPage({ vm, editorCatalog, rolePermissionNames, membersTabHr
)}
{/* M04A / M04B — basics step (S 560) */}
<Dialog open={basics !== null} onOpenChange={(open: boolean) => (open ? undefined : setBasics(null))}>
<Dialog.Content className="w-[560px] max-w-[90vw] p-6">
{basics ? <RoleBasicsDialog state={basics} onChange={setBasics} onContinue={continueToPermissions} onCancel={() => setBasics(null)} /> : <div />}
</Dialog.Content>
</Dialog>
{basics ? (
<RoleBasicsDialog state={basics} onChange={setBasics} onContinue={continueToPermissions} onCancel={() => setBasics(null)} />
) : null}
{/* M02 — large permission editor (L 1200) */}
<Dialog open={editor !== null} onOpenChange={(open: boolean) => (open ? undefined : setEditor(null))}>
<Dialog.Content className="w-[1200px] max-w-[95vw] p-6">
{editor ? (
<RoleEditorDialog
state={editor}
onChange={setEditor}
editorCatalog={editorCatalog}
submitting={submitting}
errorMessage={errorMessage}
onCancel={() => setEditor(null)}
onSave={() => {
const input = { name: editor.name, description: editor.description, permissionNames: [...editor.enabled] };
if (editor.roleId) actions.onUpdate(editor.roleId, input);
else actions.onCreate(input);
}}
/>
) : (
<div />
)}
</Dialog.Content>
</Dialog>
{editor ? (
<RoleEditorDialog
state={editor}
onChange={setEditor}
editorCatalog={editorCatalog}
submitting={submitting}
errorMessage={errorMessage}
onCancel={() => setEditor(null)}
onSave={() => {
const input = { name: editor.name, description: editor.description, permissionNames: [...editor.enabled] };
if (editor.roleId) actions.onUpdate(editor.roleId, input);
else actions.onCreate(input);
}}
/>
) : null}
{/* Delete confirm / D03 blocker (XS 420) */}
<Dialog open={deleteRow !== null} onOpenChange={(open: boolean) => (open ? undefined : setDeleteRow(null))}>
<Dialog.Content className="w-[420px] max-w-[90vw] p-4">
{deleteRow ? (
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.rolesAndPermissions.roles.deleteConfirm">
<div className="flex flex-col gap-2">
<span className="text-heading-3 font-heading-3 text-text-neutral-primary">
{deleteRow.deleteBlockedInUse ? t("settings.rolesAndPermissions.deleteBlocked.title") : t("settings.rolesAndPermissions.delete.title")}
</span>
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
{deleteRow.deleteBlockedInUse
? t("settings.rolesAndPermissions.deleteBlocked.description", { name: deleteRow.name, count: deleteRow.memberCount })
: t("settings.rolesAndPermissions.delete.description", { name: deleteRow.name })}
</span>
</div>
<div className="flex w-full items-center justify-end gap-2">
<Button variant="tertiary" onClick={() => setDeleteRow(null)}>
{deleteRow.deleteBlockedInUse ? t("shared.close") : t("shared.cancel")}
{deleteRow ? (
<FormDialog
open
onOpenChange={(open: boolean) => (open ? undefined : setDeleteRow(null))}
size="xs"
uiId="ui.settings.rolesAndPermissions.roles.deleteConfirm"
title={deleteRow.deleteBlockedInUse ? t("settings.rolesAndPermissions.deleteBlocked.title") : t("settings.rolesAndPermissions.delete.title")}
footer={
<>
<Button className="mobile:w-full" variant="tertiary" onClick={() => setDeleteRow(null)}>
{deleteRow.deleteBlockedInUse ? t("shared.close") : t("shared.cancel")}
</Button>
{!deleteRow.deleteBlockedInUse ? (
<Button
className="mobile:w-full"
variant="destructive"
loading={submitting}
onClick={() => actions.onDelete(deleteRow.id)}
data-ui-id="ui.settings.rolesAndPermissions.roles.deleteSubmit"
>
{t("shared.delete")}
</Button>
{!deleteRow.deleteBlockedInUse ? (
<Button
variant="destructive"
loading={submitting}
onClick={() => actions.onDelete(deleteRow.id)}
data-ui-id="ui.settings.rolesAndPermissions.roles.deleteSubmit"
>
{t("shared.delete")}
</Button>
) : null}
</div>
</div>
) : (
<div />
)}
</Dialog.Content>
</Dialog>
) : null}
</>
}
>
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
{deleteRow.deleteBlockedInUse
? t("settings.rolesAndPermissions.deleteBlocked.description", { name: deleteRow.name, count: deleteRow.memberCount })
: t("settings.rolesAndPermissions.delete.description", { name: deleteRow.name })}
</span>
</FormDialog>
) : null}
</div>
);
}
@@ -363,34 +366,39 @@ function RoleBasicsDialog({
const nameMissing = state.name.trim().length === 0;
return (
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.rolesAndPermissions.roles.basics">
<div className="flex flex-col gap-2">
<span className="text-heading-3 font-heading-3 text-text-neutral-primary">
{isDuplicate ? t("settings.rolesAndPermissions.duplicate.title") : t("settings.rolesAndPermissions.createDialog.title")}
</span>
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
{isDuplicate
? t("settings.rolesAndPermissions.duplicate.hint", { name: state.source?.name ?? "" })
: t("settings.rolesAndPermissions.createDialog.description")}
</span>
</div>
<div className="flex w-full flex-col gap-4">
<TextInput className="w-full" label={t("models.role.name")} showLabel>
<TextInput.Input value={state.name} onChange={(event) => onChange({ ...state, name: event.target.value })} required />
</TextInput>
<TextArea className="w-full" label={t("models.role.description")} showLabel>
<TextArea.Input value={state.description} onChange={(event) => onChange({ ...state, description: event.target.value })} />
</TextArea>
</div>
<div className="flex w-full items-center justify-end gap-2">
<Button variant="tertiary" onClick={onCancel}>
{t("shared.cancel")}
</Button>
<Button disabled={nameMissing} onClick={() => onContinue(state)} data-ui-id="ui.settings.rolesAndPermissions.roles.basics.continue">
{t("settings.rolesAndPermissions.editor.continue")}
</Button>
</div>
</div>
<FormDialog
open
onOpenChange={(open: boolean) => (open ? undefined : onCancel())}
uiId="ui.settings.rolesAndPermissions.roles.basics"
title={isDuplicate ? t("settings.rolesAndPermissions.duplicate.title") : t("settings.rolesAndPermissions.createDialog.title")}
subtitle={
isDuplicate
? t("settings.rolesAndPermissions.duplicate.hint", { name: state.source?.name ?? "" })
: t("settings.rolesAndPermissions.createDialog.description")
}
footer={
<>
<Button className="mobile:w-full" variant="tertiary" onClick={onCancel}>
{t("shared.cancel")}
</Button>
<Button
className="mobile:w-full"
disabled={nameMissing}
onClick={() => onContinue(state)}
data-ui-id="ui.settings.rolesAndPermissions.roles.basics.continue"
>
{t("settings.rolesAndPermissions.editor.continue")}
</Button>
</>
}
>
<TextInput className="w-full max-w-full" label={t("models.role.name")} showLabel>
<TextInput.Input value={state.name} onChange={(event) => onChange({ ...state, name: event.target.value })} required autoFocus />
</TextInput>
<TextArea className="w-full max-w-full" label={t("models.role.description")} showLabel>
<TextArea.Input value={state.description} onChange={(event) => onChange({ ...state, description: event.target.value })} />
</TextArea>
</FormDialog>
);
}
@@ -431,18 +439,34 @@ function RoleEditorDialog({
const nameMissing = state.name.trim().length === 0;
return (
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.rolesAndPermissions.roles.editor">
<div className="flex flex-col gap-2">
<span className="text-heading-3 font-heading-3 text-text-neutral-primary">
{state.roleId ? t("settings.rolesAndPermissions.editor.title") : t("settings.rolesAndPermissions.createDialog.title")}
</span>
{state.duplicatedFromName ? (
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
{t("settings.rolesAndPermissions.duplicate.hint", { name: state.duplicatedFromName })}
</span>
) : null}
{errorMessage ? <Alert variant="error" title={errorMessage} /> : null}
</div>
<FormDialog
open
onOpenChange={(open: boolean) => (open ? undefined : onCancel())}
size="large"
uiId="ui.settings.rolesAndPermissions.roles.editor"
title={state.roleId ? t("settings.rolesAndPermissions.editor.title") : t("settings.rolesAndPermissions.createDialog.title")}
subtitle={state.duplicatedFromName ? t("settings.rolesAndPermissions.duplicate.hint", { name: state.duplicatedFromName }) : undefined}
// The editor's permission column scrolls on its own, so the body must not
// add a second scroll container around it.
bodyClassName="max-h-none overflow-visible"
footer={
<>
<Button className="mobile:w-full" variant="tertiary" onClick={onCancel}>
{t("shared.cancel")}
</Button>
<Button
className="mobile:w-full"
loading={submitting}
disabled={nameMissing}
onClick={onSave}
data-ui-id="ui.settings.rolesAndPermissions.roles.editor.save"
>
{t("shared.save")}
</Button>
</>
}
>
{errorMessage ? <Alert variant="error" title={errorMessage} /> : null}
<div className="flex w-full gap-6 mobile:flex-col">
{/* Sidebar: search + sections (Apple-settings pattern from David's M02) */}
@@ -517,15 +541,6 @@ function RoleEditorDialog({
)}
</div>
</div>
<div className="flex w-full items-center justify-end gap-2">
<Button variant="tertiary" onClick={onCancel}>
{t("shared.cancel")}
</Button>
<Button loading={submitting} disabled={nameMissing} onClick={onSave} data-ui-id="ui.settings.rolesAndPermissions.roles.editor.save">
{t("shared.save")}
</Button>
</div>
</div>
</FormDialog>
);
}