Refresh HiveGrid Cloud reference snapshot
This commit is contained in:
1 parent
5e99e14772
commit
7f88026f79
5955 files changed
+1177325
-188362
No files matched your search
+92
-1
@@ -6,6 +6,13 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { consumeMagicLinkToken } from "~/services/auth/magic-link.server";
|
||||
import { getUser } from "~/utils/db/users.db.server";
|
||||
import { createUserSession, getUserInfo, setLoggedUser } from "~/utils/session.server";
|
||||
import { beginAlternativeLoginMfa } from "~/services/auth/alternative-login-mfa.server";
|
||||
import { loadRequiredWebConfig } from "@hivegrid/config";
|
||||
import {
|
||||
AdminFallbackLoginRejected,
|
||||
assertAdminFallbackLoginAllowedForIdentity,
|
||||
} from "~/services/auth/admin-fallback.server";
|
||||
import { writeAdminSsoAuditEvent } from "~/modules/admin-sso/audit.server";
|
||||
import * as MagicLinkRoute from "./auth.magic-link";
|
||||
|
||||
vi.mock("react-router", async () => {
|
||||
@@ -35,6 +42,23 @@ vi.mock("~/utils/session.server", () => ({
|
||||
getUserInfo: vi.fn(),
|
||||
setLoggedUser: vi.fn(),
|
||||
}));
|
||||
vi.mock("~/services/auth/alternative-login-mfa.server", () => ({
|
||||
beginAlternativeLoginMfa: vi.fn(),
|
||||
LOGIN_MFA_CHALLENGE_PATH: "/login-mfa",
|
||||
}));
|
||||
vi.mock("@hivegrid/config", () => ({
|
||||
loadRequiredWebConfig: vi.fn(),
|
||||
}));
|
||||
vi.mock("~/services/auth/admin-fallback.server", async () => {
|
||||
const actual = await vi.importActual<typeof import("~/services/auth/admin-fallback.server")>("~/services/auth/admin-fallback.server");
|
||||
return {
|
||||
...actual,
|
||||
assertAdminFallbackLoginAllowedForIdentity: vi.fn(),
|
||||
};
|
||||
});
|
||||
vi.mock("~/modules/admin-sso/audit.server", () => ({
|
||||
writeAdminSsoAuditEvent: vi.fn(),
|
||||
}));
|
||||
|
||||
const translations: Record<string, string> = {
|
||||
"auth:magicLink.invalid.title": "Sign-in link is invalid",
|
||||
@@ -56,6 +80,10 @@ const getUserMock = vi.mocked(getUser);
|
||||
const getUserInfoMock = vi.mocked(getUserInfo);
|
||||
const setLoggedUserMock = vi.mocked(setLoggedUser);
|
||||
const createUserSessionMock = vi.mocked(createUserSession);
|
||||
const beginAlternativeLoginMfaMock = vi.mocked(beginAlternativeLoginMfa);
|
||||
const loadRequiredWebConfigMock = vi.mocked(loadRequiredWebConfig);
|
||||
const assertAdminFallbackLoginAllowedForIdentityMock = vi.mocked(assertAdminFallbackLoginAllowedForIdentity);
|
||||
const writeAdminSsoAuditEventMock = vi.mocked(writeAdminSsoAuditEvent);
|
||||
|
||||
function renderMagicLinkStatus(status: "invalid" | "expired" | "replayed" | "not-found" | "purpose-mismatch") {
|
||||
vi.mocked(useLoaderData).mockReturnValue({ status });
|
||||
@@ -78,9 +106,11 @@ function callLoader(url: string, init?: RequestInit) {
|
||||
describe("auth magic-link route", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
loadRequiredWebConfigMock.mockReturnValue({ magicLink: { enabled: true } } as ReturnType<typeof loadRequiredWebConfig>);
|
||||
getUserInfoMock.mockResolvedValue({ lng: "en", userId: "existing-user" } as Awaited<ReturnType<typeof getUserInfo>>);
|
||||
setLoggedUserMock.mockResolvedValue({ userId: "user_1" } as Awaited<ReturnType<typeof setLoggedUser>>);
|
||||
createUserSessionMock.mockResolvedValue(new Response(null, { status: 302, headers: { Location: "/" } }) as Awaited<ReturnType<typeof createUserSession>>);
|
||||
beginAlternativeLoginMfaMock.mockResolvedValue({ required: false });
|
||||
});
|
||||
|
||||
it.each([
|
||||
@@ -111,6 +141,16 @@ describe("auth magic-link route", () => {
|
||||
expect(createUserSessionMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("does not consume tokens while magic-link authentication is disabled", async () => {
|
||||
loadRequiredWebConfigMock.mockReturnValue({ magicLink: { enabled: false } } as ReturnType<typeof loadRequiredWebConfig>);
|
||||
|
||||
await expect(callLoader("https://example.test/auth/magic-link?token=still-valid")).resolves.toEqual({ status: "invalid" });
|
||||
|
||||
expect(consumeMagicLinkTokenMock).not.toHaveBeenCalled();
|
||||
expect(getUserMock).not.toHaveBeenCalled();
|
||||
expect(createUserSessionMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it.each(["invalid", "expired", "replayed", "not-found", "purpose-mismatch"] as const)(
|
||||
"returns a generic failure state for %s tokens without creating a session",
|
||||
async (reason) => {
|
||||
@@ -138,6 +178,33 @@ describe("auth magic-link route", () => {
|
||||
expect(createUserSessionMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects a resolved AdminUser before MFA or session creation when fallback is disabled", async () => {
|
||||
consumeMagicLinkTokenMock.mockResolvedValue({ ok: true, userId: "admin_user_1", tokenId: "token_1", purpose: "login" });
|
||||
getUserMock.mockResolvedValue({
|
||||
id: "admin_user_1",
|
||||
email: "admin@example.test",
|
||||
defaultTenantId: null,
|
||||
locale: "de",
|
||||
admin: { userId: "admin_user_1" },
|
||||
} as never);
|
||||
assertAdminFallbackLoginAllowedForIdentityMock.mockImplementationOnce(() => {
|
||||
throw new AdminFallbackLoginRejected("disabled");
|
||||
});
|
||||
|
||||
await expect(callLoader("https://example.test/auth/magic-link?token=valid-admin-token")).resolves.toEqual({ status: "invalid" });
|
||||
|
||||
expect(beginAlternativeLoginMfaMock).not.toHaveBeenCalled();
|
||||
expect(setLoggedUserMock).not.toHaveBeenCalled();
|
||||
expect(createUserSessionMock).not.toHaveBeenCalled();
|
||||
expect(writeAdminSsoAuditEventMock).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
action: "admin.login.fallback.failure",
|
||||
actorAdminUserId: "admin_user_1",
|
||||
meta: expect.objectContaining({ method: "magic-link", stage: "consume", reason: "disabled" }),
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
it("creates a fresh session only after a valid login-purpose token resolves to a user", async () => {
|
||||
consumeMagicLinkTokenMock.mockResolvedValue({ ok: true, userId: "user_1", tokenId: "token_1", purpose: "login" });
|
||||
getUserMock.mockResolvedValue({ id: "user_1", email: "ada@example.test", defaultTenantId: "tenant_1", locale: "de" } as Awaited<ReturnType<typeof getUser>>);
|
||||
@@ -157,10 +224,34 @@ describe("auth magic-link route", () => {
|
||||
lng: "de",
|
||||
userId: "user_1",
|
||||
},
|
||||
"/"
|
||||
"/",
|
||||
{ request: expect.any(Request), rotate: true },
|
||||
);
|
||||
});
|
||||
|
||||
it("transitions a TOTP user to pending MFA without issuing a full session", async () => {
|
||||
consumeMagicLinkTokenMock.mockResolvedValue({ ok: true, userId: "user_1", tokenId: "token_1", purpose: "login" });
|
||||
getUserMock.mockResolvedValue({ id: "user_1", email: "ada@example.test", defaultTenantId: "tenant_1", locale: "de" } as never);
|
||||
beginAlternativeLoginMfaMock.mockResolvedValue({ required: true, setCookie: "hivegrid_session=pending; HttpOnly" });
|
||||
const requestUrl = "https://example.test/auth/magic-link?token=valid-token";
|
||||
|
||||
const response = await callLoader(requestUrl);
|
||||
|
||||
expect(response).toBeInstanceOf(Response);
|
||||
expect((response as Response).status).toBe(302);
|
||||
expect((response as Response).headers.get("Location")).toBe("/login-mfa");
|
||||
expect((response as Response).headers.get("Set-Cookie")).toContain("hivegrid_session=pending");
|
||||
expect(beginAlternativeLoginMfaMock).toHaveBeenCalledWith({
|
||||
request: expect.any(Request),
|
||||
userId: "user_1",
|
||||
redirectTo: "/",
|
||||
primaryMethod: "magic-link",
|
||||
});
|
||||
expect(getUserInfoMock).not.toHaveBeenCalled();
|
||||
expect(setLoggedUserMock).not.toHaveBeenCalled();
|
||||
expect(createUserSessionMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("has no action export, so unsafe HTTP methods stay outside the route module", () => {
|
||||
expect("action" in MagicLinkRoute).toBe(false);
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user