Refresh HiveGrid Cloud reference snapshot
This commit is contained in:
1 parent
5e99e14772
commit
7f88026f79
5955 files changed
+1177325
-188362
No files matched your search
+137
-17
@@ -1,12 +1,24 @@
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { consumeMagicLinkToken, createSignedMagicLinkToken, issueMagicLink, verifySignedMagicLinkToken } from "./magic-link.server";
|
||||
import {
|
||||
consumeMagicLinkToken,
|
||||
createSignedMagicLinkToken,
|
||||
issueMagicLink,
|
||||
MagicLinkDisabledError,
|
||||
verifySignedMagicLinkToken,
|
||||
} from "./magic-link.server";
|
||||
import { loadRequiredWebConfig } from "@hivegrid/config";
|
||||
import { getAppConfiguration } from "~/utils/db/appConfiguration.db.server";
|
||||
import { getMailTranslator, getMailTranslatorFromRequest } from "~/locale/mail-translator.server";
|
||||
import { queueTransactionalEmail } from "~/modules/emails/services/TransactionalEmailQueue.server";
|
||||
import { db } from "~/utils/db.server";
|
||||
import { getRlsExecutionContext, runWithRlsContext } from "@hivegrid/db/rls-context.server";
|
||||
|
||||
vi.mock("@hivegrid/config", () => ({
|
||||
loadRequiredWebConfig: vi.fn(() => ({ cryptoSecret: "test-secret", sessionSecret: "session-secret" })),
|
||||
loadRequiredWebConfig: vi.fn(() => ({
|
||||
cryptoSecret: "test-secret",
|
||||
sessionSecret: "session-secret",
|
||||
magicLink: { enabled: true },
|
||||
})),
|
||||
}));
|
||||
|
||||
vi.mock("~/utils/db.server", () => ({
|
||||
@@ -14,7 +26,7 @@ vi.mock("~/utils/db.server", () => ({
|
||||
magicLinkToken: {
|
||||
create: vi.fn(),
|
||||
findUnique: vi.fn(),
|
||||
update: vi.fn(),
|
||||
updateMany: vi.fn(),
|
||||
},
|
||||
user: {
|
||||
findUnique: vi.fn(),
|
||||
@@ -45,11 +57,17 @@ const getMailTranslatorFromRequestMock = vi.mocked(getMailTranslatorFromRequest)
|
||||
const queueTransactionalEmailMock = vi.mocked(queueTransactionalEmail);
|
||||
const magicLinkTokenCreateMock = vi.mocked(db.magicLinkToken.create);
|
||||
const magicLinkTokenFindUniqueMock = vi.mocked(db.magicLinkToken.findUnique);
|
||||
const magicLinkTokenUpdateMock = vi.mocked(db.magicLinkToken.update);
|
||||
const magicLinkTokenUpdateManyMock = vi.mocked(db.magicLinkToken.updateMany);
|
||||
const userFindUniqueMock = vi.mocked(db.user.findUnique);
|
||||
const loadRequiredWebConfigMock = vi.mocked(loadRequiredWebConfig);
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
loadRequiredWebConfigMock.mockReturnValue({
|
||||
cryptoSecret: "test-secret",
|
||||
sessionSecret: "session-secret",
|
||||
magicLink: { enabled: true },
|
||||
} as ReturnType<typeof loadRequiredWebConfig>);
|
||||
getAppConfigurationMock.mockResolvedValue({
|
||||
app: { name: "Acme Portal" },
|
||||
email: { fromName: "Acme Support", supportEmail: "support@acme.test" },
|
||||
@@ -57,7 +75,28 @@ beforeEach(() => {
|
||||
} as Awaited<ReturnType<typeof getAppConfiguration>>);
|
||||
getMailTranslatorMock.mockResolvedValue({
|
||||
locale: "de",
|
||||
t: (key, vars) => (key === "magicLink.subject" ? `Dein Anmeldelink für ${vars?.productName}` : key),
|
||||
t: (key, vars) => {
|
||||
const copy: Record<string, string> = {
|
||||
"magicLink.subject": `Dein Anmeldelink für ${vars?.productName}`,
|
||||
"magicLink.previewText": `Sicher bei ${vars?.productName} anmelden`,
|
||||
"magicLink.eyebrow": "Anmeldelink",
|
||||
"magicLink.title_named": `Hallo, ${vars?.name}!`,
|
||||
"magicLink.title": "Hallo!",
|
||||
"magicLink.intro": `Nutze diesen Link, um dich bei deinem ${vars?.productName}-Konto anzumelden.`,
|
||||
"magicLink.actionLabel": "Anmelden",
|
||||
"magicLink.ignoreIfUnrequested": "Wenn du diesen Anmeldelink nicht angefordert hast, kannst du diese E-Mail ignorieren.",
|
||||
"magicLink.outro": `Dieser Link läuft in ${vars?.expiresInMinutes} Minuten ab und kann nur einmal verwendet werden.`,
|
||||
"common.signoff.thanks": "Danke,",
|
||||
"common.legal.privacyLabel": "Datenschutz",
|
||||
"common.legal.termsLabel": "AGB",
|
||||
"common.legal.imprintLabel": "Impressum",
|
||||
"common.legal.unsubscribeLabel": "Abmelden",
|
||||
"common.support.htmlBefore": "Bei Fragen kannst du uns gerne",
|
||||
"common.support.emailLinkLabel": "eine E-Mail schreiben",
|
||||
"common.support.htmlAfter": ".",
|
||||
};
|
||||
return copy[key] ?? key;
|
||||
},
|
||||
});
|
||||
getMailTranslatorFromRequestMock.mockResolvedValue({
|
||||
locale: "en",
|
||||
@@ -66,11 +105,30 @@ beforeEach(() => {
|
||||
queueTransactionalEmailMock.mockResolvedValue({ enqueued: true, jobId: "job_1" });
|
||||
magicLinkTokenCreateMock.mockResolvedValue({ id: "token_1" } as Awaited<ReturnType<typeof db.magicLinkToken.create>>);
|
||||
magicLinkTokenFindUniqueMock.mockResolvedValue(null);
|
||||
magicLinkTokenUpdateMock.mockResolvedValue({ id: "token_1" } as Awaited<ReturnType<typeof db.magicLinkToken.update>>);
|
||||
magicLinkTokenUpdateManyMock.mockResolvedValue({ count: 1 });
|
||||
userFindUniqueMock.mockResolvedValue({ locale: "de" } as Awaited<ReturnType<typeof db.user.findUnique>>);
|
||||
});
|
||||
|
||||
describe("issueMagicLink", () => {
|
||||
it("does not persist or send a token while the provider is disabled", async () => {
|
||||
loadRequiredWebConfigMock.mockReturnValue({
|
||||
cryptoSecret: "test-secret",
|
||||
sessionSecret: "session-secret",
|
||||
magicLink: { enabled: false },
|
||||
} as ReturnType<typeof loadRequiredWebConfig>);
|
||||
|
||||
await expect(
|
||||
issueMagicLink({
|
||||
request: new Request("https://example.com/login"),
|
||||
userId: "user_1",
|
||||
email: "ada@example.com",
|
||||
})
|
||||
).rejects.toBeInstanceOf(MagicLinkDisabledError);
|
||||
|
||||
expect(magicLinkTokenCreateMock).not.toHaveBeenCalled();
|
||||
expect(queueTransactionalEmailMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("queues a magic-link mail rendered through the React-Email pipeline", async () => {
|
||||
const result = await issueMagicLink({
|
||||
request: new Request("https://example.com/forgot-password"),
|
||||
@@ -81,7 +139,7 @@ describe("issueMagicLink", () => {
|
||||
});
|
||||
|
||||
expect(result.token).toMatch(/\./);
|
||||
// Translator is resolved against the user's locale for the subject.
|
||||
// Translator is resolved against the user's locale for the complete mail.
|
||||
expect(getMailTranslatorMock).toHaveBeenCalledWith("de");
|
||||
expect(getMailTranslatorFromRequestMock).not.toHaveBeenCalled();
|
||||
expect(queueTransactionalEmailMock).toHaveBeenCalledOnce();
|
||||
@@ -101,11 +159,32 @@ describe("issueMagicLink", () => {
|
||||
);
|
||||
|
||||
const queued = queueTransactionalEmailMock.mock.calls[0]?.[0];
|
||||
expect(queued?.body).toContain("Click the button below to sign in to your Acme Portal account. No password required.");
|
||||
expect(queued?.body).toContain("Sign in");
|
||||
expect(queued?.body).toContain("This link expires in 15 minutes");
|
||||
expect(queued?.body).toContain("Nutze diesen Link, um dich bei deinem Acme Portal-Konto anzumelden.");
|
||||
expect(queued?.body).toContain("Anmelden");
|
||||
expect(queued?.body).toContain("Dieser Link läuft in 15 Minuten ab");
|
||||
expect(queued?.body).toContain("Datenschutz");
|
||||
expect(queued?.body).toContain('<html lang="de">');
|
||||
expect(queued?.body).not.toContain("Click the button below");
|
||||
expect(queued?.body).not.toContain("This link expires");
|
||||
expect(queued?.body).not.toContain("{i18nT(");
|
||||
});
|
||||
|
||||
it("reuses an already-bound matching user RLS context", async () => {
|
||||
magicLinkTokenCreateMock.mockImplementationOnce(async () => {
|
||||
expect(getRlsExecutionContext()).toEqual({ userId: "user_1" });
|
||||
return { id: "token_1" } as Awaited<ReturnType<typeof db.magicLinkToken.create>>;
|
||||
});
|
||||
|
||||
await runWithRlsContext({ userId: "user_1" }, () =>
|
||||
issueMagicLink({
|
||||
request: new Request("https://example.com/login"),
|
||||
userId: "user_1",
|
||||
email: "ada@example.com",
|
||||
}),
|
||||
);
|
||||
|
||||
expect(getRlsExecutionContext()).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("signed magic-link tokens", () => {
|
||||
@@ -130,6 +209,19 @@ describe("signed magic-link tokens", () => {
|
||||
});
|
||||
|
||||
describe("consumeMagicLinkToken", () => {
|
||||
it("does not read or consume outstanding tokens while the provider is disabled", async () => {
|
||||
const issued = createSignedMagicLinkToken({ userId: "user_1", tokenId: "token_1" });
|
||||
loadRequiredWebConfigMock.mockReturnValue({
|
||||
cryptoSecret: "test-secret",
|
||||
sessionSecret: "session-secret",
|
||||
magicLink: { enabled: false },
|
||||
} as ReturnType<typeof loadRequiredWebConfig>);
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { expectedPurpose: "login" })).resolves.toEqual({ ok: false, reason: "invalid" });
|
||||
expect(magicLinkTokenFindUniqueMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("consumes a valid matching token exactly once", async () => {
|
||||
const now = new Date("2026-05-19T12:00:00.000Z");
|
||||
const issued = createSignedMagicLinkToken({ userId: "user_1", tokenId: "token_1", now, purpose: "login" });
|
||||
@@ -147,19 +239,47 @@ describe("consumeMagicLinkToken", () => {
|
||||
tokenId: "token_1",
|
||||
purpose: "login",
|
||||
});
|
||||
expect(magicLinkTokenUpdateMock).toHaveBeenCalledWith({
|
||||
where: { id: "token_1" },
|
||||
expect(magicLinkTokenUpdateManyMock).toHaveBeenCalledWith({
|
||||
where: {
|
||||
id: "token_1",
|
||||
userId: "user_1",
|
||||
tokenHash: issued.tokenHash,
|
||||
consumedAt: null,
|
||||
expiresAt: { gt: now },
|
||||
},
|
||||
data: { consumedAt: now },
|
||||
});
|
||||
});
|
||||
|
||||
it("allows only one winner when concurrent requests race to consume the same token", async () => {
|
||||
const now = new Date("2026-05-19T12:00:00.000Z");
|
||||
const issued = createSignedMagicLinkToken({ userId: "user_1", tokenId: "token_1", now });
|
||||
magicLinkTokenFindUniqueMock.mockResolvedValue({
|
||||
id: "token_1",
|
||||
userId: "user_1",
|
||||
tokenHash: issued.tokenHash,
|
||||
expiresAt: issued.expiresAt,
|
||||
consumedAt: null,
|
||||
} as Awaited<ReturnType<typeof db.magicLinkToken.findUnique>>);
|
||||
magicLinkTokenUpdateManyMock.mockResolvedValueOnce({ count: 1 }).mockResolvedValueOnce({ count: 0 });
|
||||
|
||||
const results = await Promise.all([consumeMagicLinkToken(issued.token, { now }), consumeMagicLinkToken(issued.token, { now })]);
|
||||
|
||||
expect(results).toEqual(
|
||||
expect.arrayContaining([
|
||||
{ ok: true, userId: "user_1", tokenId: "token_1", purpose: "login" },
|
||||
{ ok: false, reason: "replayed" },
|
||||
])
|
||||
);
|
||||
});
|
||||
|
||||
it("rejects unknown or mismatched stored tokens without consuming them", async () => {
|
||||
const now = new Date("2026-05-19T12:00:00.000Z");
|
||||
const issued = createSignedMagicLinkToken({ userId: "user_1", tokenId: "token_1", now });
|
||||
magicLinkTokenFindUniqueMock.mockResolvedValue(null);
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { now })).resolves.toEqual({ ok: false, reason: "not-found" });
|
||||
expect(magicLinkTokenUpdateMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects expired signed payloads before reading the database", async () => {
|
||||
@@ -169,7 +289,7 @@ describe("consumeMagicLinkToken", () => {
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { now })).resolves.toEqual({ ok: false, reason: "expired" });
|
||||
expect(magicLinkTokenFindUniqueMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects stored tokens that expired after a valid signed payload was issued", async () => {
|
||||
@@ -189,7 +309,7 @@ describe("consumeMagicLinkToken", () => {
|
||||
} as Awaited<ReturnType<typeof db.magicLinkToken.findUnique>>);
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { now })).resolves.toEqual({ ok: false, reason: "expired" });
|
||||
expect(magicLinkTokenUpdateMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects replayed tokens before writing a new consumedAt", async () => {
|
||||
@@ -204,7 +324,7 @@ describe("consumeMagicLinkToken", () => {
|
||||
} as Awaited<ReturnType<typeof db.magicLinkToken.findUnique>>);
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { now })).resolves.toEqual({ ok: false, reason: "replayed" });
|
||||
expect(magicLinkTokenUpdateMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects purpose mismatches without consuming the token", async () => {
|
||||
@@ -219,6 +339,6 @@ describe("consumeMagicLinkToken", () => {
|
||||
} as Awaited<ReturnType<typeof db.magicLinkToken.findUnique>>);
|
||||
|
||||
await expect(consumeMagicLinkToken(issued.token, { now, expectedPurpose: "login" })).resolves.toEqual({ ok: false, reason: "purpose-mismatch" });
|
||||
expect(magicLinkTokenUpdateMock).not.toHaveBeenCalled();
|
||||
expect(magicLinkTokenUpdateManyMock).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user