Refresh HiveGrid Cloud reference snapshot
This commit is contained in:
1 parent
5e99e14772
commit
7f88026f79
5955 files changed
+1177325
-188362
No files matched your search
@@ -8,12 +8,14 @@
|
||||
|
||||
Web bundle growth is silent unless we measure it. The boilerplate tracks two complementary signals:
|
||||
|
||||
1. **Group budgets** (`BUDGETS` constant in `verify-bundle-size.mjs`): coarse caps for `root` / `initial_payload_js` / `vendor` / `route` / `other` / `css` / `total_js` / `manifest_js`. Hard CI gate — failure exits 1.
|
||||
2. **Per-route + per-vendor-chunk budgets** (`scripts/bundle-budgets.json`): fine-grained gzip limits per route and per vendor chunk. **Non-blocking** — surfaces as a PR-comment with a Δ-from-main column. Reviewers decide whether growth is justified.
|
||||
1. **Group budgets** (`BUDGETS` constant in `verify-bundle-size.mjs`): coarse caps for `root` / `initial_payload_js` / `vendor` / `route` / `other` / `lazy_runtime` / `application_js` / `total_js` / `css` / `manifest_js`. Hard CI gate — failure exits 1.
|
||||
2. **Per-route, per-vendor and per-lazy-runtime budgets** (`scripts/bundle-budgets.json`): fine-grained gzip limits for routes, vendor chunks and self-hosted feature runtimes/workers. **Non-blocking** — surfaces as a PR-comment with a Δ-from-main column. Reviewers decide whether growth is justified.
|
||||
|
||||
The per-route layer was added in task #71 (Phase 10) to make day-to-day creep visible without blocking legitimate feature work.
|
||||
|
||||
`initial_payload_js` is a dedicated hard signal for the boot asset aggregate the current parser can identify without reading Rollup/Vite dependency graphs: `entry.client-*`, `root-*`, and `manifest-*`. It intentionally excludes route, vendor, and component chunks so lazy feature payloads cannot hide a shell regression in `total_js`.
|
||||
`initial_payload_js` recursively follows the static imports of the React Router entry and root modules. Dynamic imports stay outside that boot signal.
|
||||
|
||||
Self-hosted feature runtimes need a separate signal. `lazy_runtime` contains Monaco, PDF.js and emitted Web Worker entry points: these bytes replaced executable CDN downloads and are loaded only when the feature or worker is activated. `application_js` preserves the pre-self-hosting cap for the app itself, while `total_js` still caps every emitted JavaScript byte including lazy runtimes. This keeps CDN removal from weakening either critical-path or overall artifact controls.
|
||||
|
||||
## Config schema
|
||||
|
||||
@@ -24,11 +26,15 @@ The per-route layer was added in task #71 (Phase 10) to make day-to-day creep vi
|
||||
"default": { "limitKb": 200, "warningKb": 180 },
|
||||
"routes": {
|
||||
"app/$tenant/dashboard": { "limitKb": 250, "warningKb": 225 },
|
||||
"auth/magic-link": { "limitKb": 80, "warningKb": 75 }
|
||||
"auth/magic-link": { "limitKb": 80, "warningKb": 75 },
|
||||
},
|
||||
"vendorChunks": {
|
||||
"vendor-react": { "limitKb": 150, "warningKb": 135 }
|
||||
}
|
||||
"vendor-react": { "limitKb": 150, "warningKb": 135 },
|
||||
},
|
||||
"lazyRuntimeChunks": {
|
||||
"MonacoEditor.client": { "limitKb": 1000, "warningKb": 950 },
|
||||
"ts.worker": { "limitKb": 1550, "warningKb": 1520 },
|
||||
},
|
||||
}
|
||||
```
|
||||
|
||||
@@ -38,6 +44,7 @@ The per-route layer was added in task #71 (Phase 10) to make day-to-day creep vi
|
||||
- Routes use React Router v7 route ids in either dot- or slash-form (`auth/magic-link` and `auth.magic-link` both match).
|
||||
- Unmatched routes fall back to `default`.
|
||||
- Unmatched vendor chunks (anything starting with `vendor-` or `chunk-`) are reported under the chunk basename and also fall back to `default`.
|
||||
- Monaco/PDF.js chunks and `*.worker-*` entry points use `lazyRuntimeChunks`; these budgets make formerly hidden CDN payloads reviewable without treating them as route modules.
|
||||
|
||||
## Local workflow
|
||||
|
||||
@@ -71,15 +78,17 @@ The visualizer is gated on `ANALYZE_BUNDLE=true` so the regular production build
|
||||
|
||||
**Security note:** `stats.html` contains source-map references and should never be deployed publicly. Treat it as a developer-only artifact.
|
||||
|
||||
## PR-comment workflow
|
||||
## Gitea workflow
|
||||
|
||||
`.github/workflows/bundle-budget.yml` (and `.gitea/workflows/bundle-budget.yml`) run on every PR that touches `apps/web/**`, `packages/**`, or the budget config / verifier. They:
|
||||
`.gitea/workflows/bundle-budget.yml` runs on every relevant Gitea pull request. The dedicated workflow keeps the expensive web build outside the default CI lane while still enforcing the aggregate budget.
|
||||
|
||||
The workflow:
|
||||
|
||||
1. Build `@hivegrid/web`.
|
||||
2. Run `verify-bundle-size.mjs --json`.
|
||||
3. Download the latest `bundle-baseline-main` artifact (captured by `bundle-budget-baseline.yml` on `main` pushes).
|
||||
4. Render a sticky markdown comment via `scripts/render-bundle-budget-comment.mjs`.
|
||||
5. Upsert the comment using its `<!-- bundle-budget-report -->` marker (GitHub: `marocchino/sticky-pull-request-comment`; Gitea: `scripts/post-bundle-budget-gitea-comment.mjs`).
|
||||
4. Render a markdown report via `scripts/render-bundle-budget-comment.mjs`.
|
||||
5. Upload the JSON and Markdown reports as Gitea Actions artifacts.
|
||||
|
||||
The comment renders rows in severity order (`[EXCEED]` → `[WARN]` → unbudgeted → ok), with columns: status / kind / route or chunk key / current gzip size / configured limit / Δ from main. Δ is `—` if no baseline is available.
|
||||
|
||||
@@ -90,20 +99,20 @@ The first PR after a fresh checkout (or after a baseline-artifact expiry) sees `
|
||||
## When to raise a limit
|
||||
|
||||
1. Confirm the growth is intentional (a new feature shipped, a dependency landed) — not a regression from accidental imports.
|
||||
2. Open the PR; the bundle-budget comment shows the Δ. Reviewers and the PR author should agree the new floor is acceptable.
|
||||
2. Open the pull request; the bundle-budget artifact shows the Δ. Reviewers and the author should agree the new floor is acceptable.
|
||||
3. Edit `scripts/bundle-budgets.json` in the **same PR** that ships the growth. Bump `warningKb` to ≈ (current gzip + 5 KB) and `limitKb` to ≈ (current gzip + 20 KB).
|
||||
4. Call the change out in the PR description so the new floor is reviewable.
|
||||
|
||||
## Anti-patterns
|
||||
|
||||
- **Don't disable a budget by raising it to 9999 KB.** The point is to surface drift. If a route is legitimately huge, raise the limit to a tight new floor, not infinity.
|
||||
- **Don't lazy-load critical-path code.** Bundle splits help non-critical routes, but the initial payload (`entry.client-*` / `root-*` / `manifest-*`) still has its own `initial_payload_js` hard group budget that must stay tight.
|
||||
- **Don't lazy-load critical-path code.** Bundle splits help non-critical routes, but the recursively measured entry/root static graph still has its own `initial_payload_js` hard group budget that must stay tight.
|
||||
- **Don't bundle-split shared deps.** Splitting `react` into many chunks just shifts cost into chunk boot-up. Keep `vendor-react`, `vendor-core-utils` etc. as single chunks; the manualChunks mapping in `apps/web/app/utils/build/manualChunks.ts` is the source of truth.
|
||||
|
||||
## Troubleshooting
|
||||
|
||||
- **PR comment never shows up:** check the `Bundle Budget` workflow run — the `Build web` step may have failed (e.g. server-only import in a client export). The comment job only runs if all upstream steps succeed.
|
||||
- **`vendor-monaco-...` reports as `vendor-monaco-...-` with default budget:** rollup occasionally emits chunk hashes ending in `-`; the baseline normalizer skips that suffix and the asset falls back to `default`. Either rename via `manualChunks.ts` or add an explicit budget entry.
|
||||
- **Report artifact fehlt:** check the `Bundle Budget` workflow run — the `Build web` step may have failed (e.g. server-only import in a client export).
|
||||
- **A worker appears as a route:** worker filenames must match `*.worker-*` (or PDF.js's `*.worker.min-*`) so the verifier puts them in `lazy_runtime`; update the narrow matcher when adding a differently named worker entry.
|
||||
- **CI run is much slower than `pnpm typecheck`:** the workflow does a full `pnpm --filter @hivegrid/web build`. That's the expected cost. If it ever exceeds ~30 minutes, profile with `ANALYZE_BUNDLE=true` locally first.
|
||||
|
||||
## Rollback
|
||||
|
||||
@@ -7,7 +7,7 @@ and how the Web-Vitals → Sentry bridge surfaces real-user metrics.
|
||||
Companion artefacts: `.lighthouserc.staging.json`,
|
||||
`.lighthouserc.json`, `scripts/lighthouse-puppeteer-auth.cjs`,
|
||||
`scripts/rotate-lighthouse-session-cookie.mjs`,
|
||||
`.github/workflows/lighthouse.yml`, `.gitea/workflows/lighthouse.yml`,
|
||||
`.gitea/workflows/lighthouse.yml`,
|
||||
`apps/web/app/lib/observability/web-vitals.ts`,
|
||||
`apps/web/app/lib/pwa/registerServiceWorker.ts`,
|
||||
`apps/web/public/manifest.webmanifest`, `apps/web/public/sw.js`.
|
||||
@@ -21,7 +21,7 @@ CI workflow audits the **deployed staging site**
|
||||
|
||||
That makes it a **post-deploy / monitoring audit, not a per-commit merge
|
||||
gate** — staging always lags the commit under review. The workflow
|
||||
(`.gitea/workflows/lighthouse.yml`, mirrored in `.github/`) runs:
|
||||
(`.gitea/workflows/lighthouse.yml`) runs:
|
||||
|
||||
- **nightly** at 03:00 UTC (`schedule`), and
|
||||
- **on demand** (`workflow_dispatch`).
|
||||
@@ -31,18 +31,17 @@ it as a production-quality alarm, not a blocked PR.
|
||||
|
||||
The Gitea runner image (`node:20-bookworm`) ships no browser, so the
|
||||
workflow installs `chromium` via `apt-get` and points LHCI at it with
|
||||
`CHROME_PATH=/usr/bin/chromium`. The GitHub runner (`ubuntu-latest`)
|
||||
already bundles Chrome.
|
||||
`CHROME_PATH=/usr/bin/chromium`.
|
||||
|
||||
## Audit targets
|
||||
|
||||
`.lighthouserc.staging.json` audits the public staging routes — the
|
||||
surface that renders without authentication:
|
||||
|
||||
| URL |
|
||||
| -------------------------------------------- |
|
||||
| `https://boiler.saas-ctrl.com/login` |
|
||||
| `https://boiler.saas-ctrl.com/privacy-policy` |
|
||||
| URL |
|
||||
| --------------------------------------------------- |
|
||||
| `https://boiler.saas-ctrl.com/login` |
|
||||
| `https://boiler.saas-ctrl.com/privacy-policy` |
|
||||
| `https://boiler.saas-ctrl.com/terms-and-conditions` |
|
||||
|
||||
Only **Performance** is a hard gate (`error`). The product is a B2B
|
||||
@@ -52,13 +51,13 @@ not asserted at all. Accessibility and Best-Practices stay visible as
|
||||
(axe-core plus the `jsx-a11y` ESLint baseline, task #73), so a second
|
||||
blocking gate here would be redundant.
|
||||
|
||||
| Category | Threshold | Severity |
|
||||
| --------------- | --------- | ------------------------- |
|
||||
| Performance | 0.95 | error |
|
||||
| Accessibility | 0.95 | warn |
|
||||
| Best Practices | 0.95 | warn |
|
||||
| PWA | 0.90 | warn |
|
||||
| SEO | — | not asserted (irrelevant) |
|
||||
| Category | Threshold | Severity |
|
||||
| -------------- | --------- | ------------------------- |
|
||||
| Performance | 0.95 | error |
|
||||
| Accessibility | 0.95 | warn |
|
||||
| Best Practices | 0.95 | warn |
|
||||
| PWA | 0.90 | warn |
|
||||
| SEO | — | not asserted (irrelevant) |
|
||||
|
||||
Numeric audits (FCP / LCP / TBT / CLS) stay at `warn` severity so trend
|
||||
regressions remain visible without failing the run.
|
||||
@@ -74,14 +73,16 @@ the cookie or password.
|
||||
|
||||
Required workflow secrets:
|
||||
|
||||
| Secret | Purpose |
|
||||
| ------ | ------- |
|
||||
| `LIGHTHOUSE_LOGIN_EMAIL` | Email of the staging Lighthouse bot user. |
|
||||
| Secret | Purpose |
|
||||
| --------------------------- | -------------------------------------------- |
|
||||
| `LIGHTHOUSE_LOGIN_EMAIL` | Email of the staging Lighthouse bot user. |
|
||||
| `LIGHTHOUSE_LOGIN_PASSWORD` | Password of the staging Lighthouse bot user. |
|
||||
|
||||
The session cookie name is `hivegrid_session`; workflows also pass
|
||||
`LIGHTHOUSE_SESSION_COOKIE_NAME=hivegrid_session` and
|
||||
`LIGHTHOUSE_COOKIE_DOMAIN=boiler.saas-ctrl.com`.
|
||||
The app session cookie name is `__Host-hivegrid_app_session`; workflows also
|
||||
pass `LIGHTHOUSE_SESSION_COOKIE_NAME=__Host-hivegrid_app_session`. The cookie
|
||||
is injected URL-bound without a `Domain` attribute so Chromium preserves the
|
||||
`__Host-` contract. `LIGHTHOUSE_COOKIE_DOMAIN=app.hivegrid.de` remains only as
|
||||
a compatibility input for local, non-prefixed cookie names.
|
||||
|
||||
During rollout the workflow still forwards the older
|
||||
`LIGHTHOUSE_SESSION_COOKIE` secret as a fallback. If the login email or
|
||||
@@ -91,9 +92,11 @@ each run mints a fresh cookie.
|
||||
|
||||
## Authenticated routes
|
||||
|
||||
Auditing `/app/$tenant/*` and `/admin/*` needs that freshly minted
|
||||
`hivegrid_session` cookie. `scripts/lighthouse-puppeteer-auth.cjs` injects the
|
||||
cookie for protected URLs and is already wired into
|
||||
Auditing app routes needs that freshly minted `__Host-hivegrid_app_session`
|
||||
cookie. Admin routes require a separately minted
|
||||
`__Host-hivegrid_admin_session`; an app cookie is intentionally never reused
|
||||
on the admin sibling host. `scripts/lighthouse-puppeteer-auth.cjs` injects the
|
||||
configured cookie for protected URLs and is already wired into
|
||||
`.lighthouserc.staging.json`. The current staging target list still
|
||||
audits only public routes; add protected URLs once the exact tenant/admin
|
||||
coverage list is chosen. Without a protected URL in the config, the
|
||||
@@ -121,7 +124,7 @@ To reproduce a CI staging finding locally, point LHCI at the staging
|
||||
config instead — no local server needed, just a Chrome install:
|
||||
|
||||
```sh
|
||||
pnpm dlx @lhci/cli@0.13.x autorun --config=./.lighthouserc.staging.json
|
||||
pnpm dlx @lhci/cli@0.13.0 autorun --config=./.lighthouserc.staging.json
|
||||
```
|
||||
|
||||
The run prints the temporary-public-storage report URLs in its output;
|
||||
@@ -130,14 +133,18 @@ share those when debugging a regression.
|
||||
## PWA manifest + service-worker
|
||||
|
||||
`apps/web/public/manifest.webmanifest` describes the installable app.
|
||||
`apps/web/public/sw.js` is a minimal cache-first / network-first service
|
||||
`apps/web/public/sw.js` is an assets-only cache-first service
|
||||
worker registered from `root.tsx` via `registerServiceWorker`.
|
||||
|
||||
Cache strategy:
|
||||
|
||||
- `/assets/...` (hashed by React-Router build) → **cache-first**
|
||||
- `/api/...`, `/app/...`, `/admin/...` → **network-first** with cache fallback
|
||||
- everything else (marketing routes, brand assets) → **network-first**
|
||||
- HTML, loader/data, API, media and all other URLs → **not intercepted**; the
|
||||
browser HTTP cache applies the origin `Cache-Control`/`Vary` contract.
|
||||
|
||||
Session-derived responses must never enter Service Worker Cache Storage. Cache
|
||||
Storage is URL-keyed and an offline fallback could otherwise expose one user's
|
||||
cached HTML or JSON to another user of the same browser profile.
|
||||
|
||||
The `CACHE_VERSION` constant inside `sw.js` is the invalidation lever —
|
||||
bump it on any deploy that changes the asset graph in a backward-
|
||||
@@ -171,14 +178,14 @@ dev, preview, staging, and production without extra gating.
|
||||
|
||||
## Troubleshooting CI runs
|
||||
|
||||
| Symptom | Likely cause / fix |
|
||||
| -------------------------------------------------- | ----------------------------------------------------------------------------- |
|
||||
| Symptom | Likely cause / fix |
|
||||
| ------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------- |
|
||||
| `Chrome installation not found` / `Healthcheck failed!` | The runner has no browser. The Gitea workflow installs `chromium`; confirm the install step ran and `CHROME_PATH` is set. |
|
||||
| Cookie rotation step fails with missing env vars | Add `LIGHTHOUSE_LOGIN_EMAIL` and `LIGHTHOUSE_LOGIN_PASSWORD` as repo Actions secrets. |
|
||||
| Audit reports the `/login` page for a protected URL | Cookie injection failed or the bot no longer belongs to the tenant/admin surface being audited. |
|
||||
| Performance score < 0.95 only on first run | Cold cache; LHCI reruns automatically (`numberOfRuns=3`). |
|
||||
| Audit times out | Lower `numberOfRuns` to 1 temporarily while iterating; restore afterwards. |
|
||||
| All URLs fail to load | Staging is down or redeploying — check the `web` container on staging. |
|
||||
| Cookie rotation step fails with missing env vars | Add `LIGHTHOUSE_LOGIN_EMAIL` and `LIGHTHOUSE_LOGIN_PASSWORD` as repo Actions secrets. |
|
||||
| Audit reports the `/login` page for a protected URL | Cookie injection failed or the bot no longer belongs to the tenant/admin surface being audited. |
|
||||
| Performance score < 0.95 only on first run | Cold cache; LHCI reruns automatically (`numberOfRuns=3`). |
|
||||
| Audit times out | Lower `numberOfRuns` to 1 temporarily while iterating; restore afterwards. |
|
||||
| All URLs fail to load | Staging is down or redeploying — check the `web` container on staging. |
|
||||
|
||||
## Updating thresholds
|
||||
|
||||
|
||||
@@ -235,7 +235,7 @@ execution later fails, stalls, or remains queued behind a missing bridge.
|
||||
|
||||
### Re-queueing failed events
|
||||
|
||||
Use `hivegrid-cli outbox requeue` after fixing the underlying receiver.
|
||||
Use `hivegrid-cli outbox requeue --tenant <tenantId>` after fixing the underlying receiver.
|
||||
The CLI supports single-row and filtered bulk requeues, `--dry-run`, JSON
|
||||
output, and guardrails that avoid replaying `PENDING` / `PROCESSING`
|
||||
rows. Prefer it over raw SQL so `processedAt`, `lastError`, retry state,
|
||||
|
||||
@@ -148,7 +148,7 @@ tenant-default subscribers remain eligible.
|
||||
### 11. Operator CLI — `packages/cli/src/commands/plugins/*`
|
||||
|
||||
```
|
||||
hivegrid-cli plugins list [--tenantId X] [--enabled true|false]
|
||||
hivegrid-cli plugins list --tenantId X [--enabled true|false]
|
||||
hivegrid-cli plugins enable --tenantId X --pluginId com.acme.slack
|
||||
hivegrid-cli plugins disable --tenantId X --pluginId com.acme.slack
|
||||
hivegrid-cli plugins uninstall --tenantId X --pluginId com.acme.slack
|
||||
|
||||
@@ -136,8 +136,11 @@ steps live with the platform operator.
|
||||
3. **App env**:
|
||||
|
||||
```sh
|
||||
DATABASE_URL=postgres://app_user:...@pgbouncer:6432/hivegrid?pgbouncer=true&connection_limit=10
|
||||
DATABASE_READ_URL=postgres://read_user:...@postgres-replica:5432/hivegrid?connection_limit=10
|
||||
DATABASE_URL=postgres://app_user:...@pgbouncer:6432/hivegrid
|
||||
DATABASE_READ_URL=postgres://read_user:...@postgres-replica:5432/hivegrid
|
||||
DATABASE_POOL_MAX=10
|
||||
DATABASE_POOL_IDLE_TIMEOUT_MS=10000
|
||||
DATABASE_POOL_CONNECTION_TIMEOUT_MS=5000
|
||||
```
|
||||
|
||||
Optionally front the replica with its own PgBouncer for connection pooling.
|
||||
@@ -193,7 +196,8 @@ steps live with the platform operator.
|
||||
(post-auth).
|
||||
- `apps/web/app/modules/sites/db/sites.db.server.ts` — read-only site
|
||||
loaders (auth-gating `getSiteByTypeAndSiteId` left on primary).
|
||||
- `apps/web/app/modules/portals/db/portals.db.server.ts` and
|
||||
- The then-existing `apps/web/app/modules/portals/db/portals.db.server.ts`
|
||||
(removed by the VA-P26a legacy recut) and the retained
|
||||
`portalPages.db.server.ts` — listings, page lookups, dashboard counts.
|
||||
|
||||
`appData.ts` was **not** migrated wholesale; only the secondary tenant
|
||||
|
||||
@@ -6,10 +6,8 @@
|
||||
This document explains how test coverage is measured, gated, and reported in the
|
||||
HiveGrid. Per-path thresholds are encoded as data in
|
||||
`scripts/coverage-targets.json` and enforced by `scripts/verify-test-coverage.mjs`.
|
||||
CI workflows run the gate on GitHub PRs and `push` to `main`, while the
|
||||
Gitea coverage workflow currently runs on pull requests. Keep
|
||||
`.github/workflows/coverage.yml`, `.gitea/workflows/coverage.yml`, and
|
||||
this policy aligned when trigger coverage changes.
|
||||
The Gitea coverage workflow runs the gate on relevant pull requests, pushes to
|
||||
`main`, and manual dispatches. The local command uses the same targets.
|
||||
|
||||
## Why
|
||||
|
||||
@@ -83,8 +81,8 @@ latest ratchet already meets or exceeds for every critical-path row (see
|
||||
3. Run `pnpm run verify:test-coverage` locally. The gate prints the actual
|
||||
coverage; set the active gate at or slightly below that number so the
|
||||
commit lands green.
|
||||
4. Open a PR. The Coverage workflow will post a sticky comment showing the
|
||||
new row in the per-path table.
|
||||
4. Open a pull request. The Coverage workflow uploads a Markdown report showing
|
||||
the new row in the per-path table.
|
||||
|
||||
## How to bump or lower a threshold
|
||||
|
||||
@@ -113,8 +111,8 @@ Bumps **down** (looser gate) — should be rare and reviewed:
|
||||
- any target's actual `statements%` < `target.statements` **or**
|
||||
actual `branches%` < `target.branches`
|
||||
|
||||
The GitHub workflow uploads `coverage/` as `coverage-report-<run_id>` even on
|
||||
failure so contributors can drill into the HTML report.
|
||||
The Gitea workflow uploads `coverage-gate/` and the rendered Markdown summary
|
||||
as `coverage-report-<run_id>` even on failure.
|
||||
|
||||
## Type-only packages
|
||||
|
||||
@@ -128,15 +126,13 @@ sprint target, then cover their contract with `expectTypeOf` tests and
|
||||
|
||||
Task #76 is completed. Keep the gate useful as a no-regression control:
|
||||
|
||||
1. Confirm `docs/testing/coverage-sprint-backlog.md` still has no
|
||||
critical-path or standard-tier positive-gap rows before release closeouts.
|
||||
2. Keep each active `statements`/`branches` gate at or above the relevant
|
||||
1. Keep each active `statements`/`branches` gate at or above the relevant
|
||||
`sprintTarget`.
|
||||
3. Treat `sprintTarget` fields as explicit release-floor annotations unless a
|
||||
2. Treat `sprintTarget` fields as explicit release-floor annotations unless a
|
||||
future cleanup removes them consistently from docs and gate data.
|
||||
4. Run `pnpm run verify:test-coverage` after threshold changes — it must pass
|
||||
3. Run `pnpm run verify:test-coverage` after threshold changes — it must pass
|
||||
with the new gates.
|
||||
5. Track additional Playwright/E2E coverage separately; it is not a blocker
|
||||
4. Track additional Playwright/E2E coverage separately; it is not a blocker
|
||||
for the completed per-module coverage gate.
|
||||
|
||||
## Out of scope (deferred to follow-up tasks)
|
||||
@@ -147,12 +143,12 @@ Task #76 is completed. Keep the gate useful as a no-regression control:
|
||||
but not delta. A future PR can add baseline-fetch + delta rendering similar
|
||||
to bundle-budget.
|
||||
- **E2E coverage via Playwright** (5 golden-path flows) — tracked separately.
|
||||
- **Additional critical-path test writing** — see
|
||||
`docs/testing/coverage-sprint-backlog.md` for the ordered backlog.
|
||||
- **Additional critical-path test writing** — create a ticket with a measured gap from the current
|
||||
`scripts/coverage-targets.json` contract.
|
||||
|
||||
## References
|
||||
|
||||
- Gate runner: `scripts/verify-test-coverage.mjs`
|
||||
- Targets data: `scripts/coverage-targets.json`
|
||||
- Summary/badge: `scripts/coverage-summary.mjs`
|
||||
- CI: `.github/workflows/coverage.yml`, `.gitea/workflows/coverage.yml`
|
||||
- CI: `.gitea/workflows/coverage.yml`
|
||||
Reference in new issue
Block a user