import fs from "node:fs"; import path from "node:path"; import { describe, expect, it } from "vitest"; const routeRoot = path.resolve(process.cwd(), "apps/web/app/routes/admin/accounts/roles-and-permissions"); function readRoute(relativePath: string) { return fs.readFileSync(path.join(routeRoot, relativePath), "utf8"); } describe("admin role assignment scoping", () => { it("restricts account user assignments to app roles and tenant members or admins", () => { const source = readRoute("account-users.$account.tsx"); expect(source).toContain("getTenantMember"); expect(source).toContain('role.type !== "app"'); expect(source).toContain("!user.admin && !tenantMember"); expect(source).toContain("createUserRole(userId, roleId, tenant.id)"); expect(source).toContain("deleteUserRole(userId, roleId, tenant.id)"); expect(source).not.toContain("createUserRole(userId, roleId, params.account)"); expect(source).not.toContain("deleteUserRole(userId, roleId, params.account)"); }); it("restricts admin user assignments to admin users and admin roles", () => { const source = readRoute("admin-users.tsx"); expect(source).toContain("!user.admin"); expect(source).toContain('role.type !== "admin"'); expect(source).toContain("createUserRole(userId, roleId)"); expect(source).toContain("deleteUserRole(userId, roleId)"); }); it("writes clean role assignment audit details", () => { const adminUsersSource = readRoute("admin-users.tsx"); const accountUsersSource = readRoute("account-users.$account.tsx"); expect(adminUsersSource).not.toContain("${role.name}}"); expect(accountUsersSource).not.toContain("${role.name}}"); expect(adminUsersSource).toContain("`${user.email} - ${role.name}`"); expect(accountUsersSource).toContain("`[${tenant.name}] ${user.email} - ${role.name}`"); }); it("uses render-translated stable audit action values", () => { const routeFiles = [ "admin-users.tsx", "account-users.$account.tsx", "permissions/new.tsx", "permissions/$id.tsx", "roles/new.tsx", "roles/$id.tsx", ]; const actions = routeFiles.flatMap((file) => { const source = readRoute(file); return Array.from(source.matchAll(/createAdminLog\s*\(\s*request,\s*"([^"]+)"/gu)) .map((match) => match[1]) .filter((action): action is string => typeof action === "string"); }); expect(actions).toContain("admin.adminUserRoles.created"); expect(actions).toContain("admin.adminUserRoles.deleted"); expect(actions).toContain("admin.accountUserRoles.created"); expect(actions).toContain("admin.accountUserRoles.deleted"); expect(actions).toContain("admin.roles.updated"); expect(actions).toContain("admin.permissions.created"); expect(actions).toContain("admin.permissions.updated"); expect(actions).toContain("admin.permissions.deleted"); expect(actions).toContain("admin.roles.created"); expect(actions).toContain("admin.roles.deleted"); expect(actions).not.toContain("Create"); expect(actions).not.toContain("Created"); expect(actions).not.toContain("Updated"); expect(actions).not.toContain("Deleted"); expect(new Set(actions)).toEqual( new Set([ "admin.adminUserRoles.created", "admin.adminUserRoles.deleted", "admin.accountUserRoles.created", "admin.accountUserRoles.deleted", "admin.permissions.created", "admin.permissions.updated", "admin.permissions.deleted", "admin.roles.created", "admin.roles.updated", "admin.roles.deleted", ]) ); }); });