201 lines
7.9 KiB
TypeScript
201 lines
7.9 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { createSharedStore, MemoryAdapter } from "@hivegrid/shared-store";
|
|
import { createHash } from "node:crypto";
|
|
|
|
vi.mock("@hivegrid/config", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("@hivegrid/config")>();
|
|
return {
|
|
...actual,
|
|
loadRequiredWebConfig: vi.fn(() => ({
|
|
routing: {
|
|
protocol: "https",
|
|
webAppHost: "app.example.test",
|
|
adminAppHost: "admin.example.test",
|
|
apiHost: "api.example.test",
|
|
appBaseDomain: "example.test",
|
|
},
|
|
})),
|
|
};
|
|
});
|
|
vi.mock("~/shared-store.server", () => ({ getSharedStore: vi.fn() }));
|
|
vi.mock("~/utils/session.server", () => ({ createUserSession: vi.fn() }));
|
|
|
|
import { createUserSession } from "~/utils/session.server";
|
|
import {
|
|
__resetSessionHandoffStoreForTests,
|
|
__setSessionHandoffStoreForTests,
|
|
consumeSessionHandoff,
|
|
createSessionHandoffRedirect,
|
|
} from "./session-handoff.server";
|
|
|
|
const userAgent = "HiveGrid security test browser";
|
|
const session = {
|
|
userId: "target-user-1",
|
|
lightOrDarkMode: "dark",
|
|
lng: "de",
|
|
cookies: [],
|
|
impersonatingFromAdminUserId: "admin-user-1",
|
|
impersonatingFromAdminEmail: "admin@example.test",
|
|
impersonatingStartedAt: "2026-07-12T06:00:00.000Z",
|
|
};
|
|
let store: ReturnType<typeof createSharedStore>;
|
|
|
|
function request(url: string, agent = userAgent) {
|
|
return new Request(url, { headers: { "user-agent": agent } });
|
|
}
|
|
|
|
function codeFrom(response: Response) {
|
|
return new URL(response.headers.get("Location")!).searchParams.get("code")!;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
store = createSharedStore({ namespace: "session-handoff-test", adapter: new MemoryAdapter() });
|
|
__setSessionHandoffStoreForTests(store);
|
|
vi.mocked(createUserSession).mockResolvedValue(
|
|
new Response(null, {
|
|
status: 302,
|
|
headers: {
|
|
Location: "https://app.example.test/acme/dashboard",
|
|
"Set-Cookie": "__Host-hivegrid_app_session=signed; Path=/; Secure; HttpOnly",
|
|
},
|
|
}) as never
|
|
);
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
__resetSessionHandoffStoreForTests();
|
|
});
|
|
|
|
describe("cross-host session handoff", () => {
|
|
it("uses a short opaque code and consumes it once on the app host", async () => {
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const location = issued.headers.get("Location")!;
|
|
const code = codeFrom(issued);
|
|
|
|
expect(location).toMatch(/^https:\/\/app\.example\.test\/auth\/session-handoff\?code=[A-Za-z0-9_-]{43}$/);
|
|
expect(location).not.toContain(session.userId);
|
|
expect(location).not.toContain(session.impersonatingFromAdminUserId);
|
|
expect(location).not.toContain(session.impersonatingFromAdminEmail);
|
|
expect(issued.headers.get("Cache-Control")).toBe("no-store");
|
|
expect(issued.headers.get("Referrer-Policy")).toBe("no-referrer");
|
|
|
|
const completed = await consumeSessionHandoff(request(`https://app.example.test/auth/session-handoff?code=${code}`), code);
|
|
expect(completed?.headers.get("Set-Cookie")).toContain("__Host-hivegrid_app_session=");
|
|
expect(completed?.headers.get("Cache-Control")).toBe("no-store");
|
|
expect(completed?.headers.get("Referrer-Policy")).toBe("no-referrer");
|
|
expect(createUserSession).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
userId: "target-user-1",
|
|
impersonatingFromAdminUserId: "admin-user-1",
|
|
impersonatingFromAdminEmail: "admin@example.test",
|
|
}),
|
|
"https://app.example.test/acme/dashboard",
|
|
{ request: expect.any(Request), rotate: true }
|
|
);
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code)).resolves.toBeNull();
|
|
});
|
|
|
|
it("allows exactly one winner under concurrent consumption", async () => {
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const code = codeFrom(issued);
|
|
|
|
const results = await Promise.all([
|
|
consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code),
|
|
consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code),
|
|
]);
|
|
expect(results.filter(Boolean)).toHaveLength(1);
|
|
expect(createUserSession).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("consumes and rejects a code presented by a different browser", async () => {
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const code = codeFrom(issued);
|
|
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff", "different-browser"), code)).resolves.toBeNull();
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code)).resolves.toBeNull();
|
|
expect(createUserSession).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("binds consumption to the canonical app origin without burning the code on another host", async () => {
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const code = codeFrom(issued);
|
|
|
|
await expect(consumeSessionHandoff(request("https://admin.example.test/auth/session-handoff"), code)).resolves.toBeNull();
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code)).resolves.toBeInstanceOf(Response);
|
|
expect(createUserSession).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("rejects a Redis payload whose HMAC envelope was tampered with", async () => {
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const code = codeFrom(issued);
|
|
const hash = createHash("sha256").update(code).digest("hex");
|
|
await store.set(
|
|
`auth:session-handoff:${hash}`,
|
|
JSON.stringify({
|
|
payload: JSON.stringify({ ...session, userId: "attacker-selected-user" }),
|
|
signature: "forged-signature",
|
|
}),
|
|
{ ttlSeconds: 60 }
|
|
);
|
|
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code)).resolves.toBeNull();
|
|
expect(createUserSession).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("fails closed for expired codes and non-app redirect targets", async () => {
|
|
vi.useFakeTimers();
|
|
vi.setSystemTime(new Date("2026-07-12T06:00:00.000Z"));
|
|
const issued = await createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
});
|
|
const code = codeFrom(issued);
|
|
vi.advanceTimersByTime(60_000);
|
|
|
|
await expect(consumeSessionHandoff(request("https://app.example.test/auth/session-handoff"), code)).resolves.toBeNull();
|
|
await expect(
|
|
createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://evil.example/phish",
|
|
})
|
|
).rejects.toThrow("canonical app-host redirect");
|
|
});
|
|
|
|
it("fails closed without emitting a redirect when the shared store is unavailable", async () => {
|
|
vi.spyOn(store, "set").mockRejectedValueOnce(new Error("redis unavailable"));
|
|
|
|
await expect(
|
|
createSessionHandoffRedirect({
|
|
request: request("https://admin.example.test/accounts/users"),
|
|
session,
|
|
redirectTo: "https://app.example.test/acme/dashboard",
|
|
})
|
|
).rejects.toThrow("redis unavailable");
|
|
expect(createUserSession).not.toHaveBeenCalled();
|
|
});
|
|
});
|