421 lines
20 KiB
TypeScript
421 lines
20 KiB
TypeScript
// R-P2b — D-P2 "WF-P2 Admin RBAC" S01 Mitarbeiterliste in David's Subframe optics.
|
|
// Pure presentational component: renders the server-built MembersListVM passed
|
|
// as a prop and reports mutations through injected actions (route posts the
|
|
// intents). No useLoaderData, no server imports (AD-28 / DoD A.5).
|
|
// S01 — list with search + role/status/2FA filters, invited rows inline
|
|
// D01 — inline role dropdown per row (checkbox items + link to S02)
|
|
// M03 — deactivate confirm as a real Dialog (XS 420, danger action)
|
|
// V01 — last-admin blocker dialog (server code "last-admin" opens it)
|
|
// Reassign-on-deactivate is Backlog/V2 by David's decision — plain confirm only.
|
|
|
|
import { useEffect, useState } from "react";
|
|
import { Link } from "react-router";
|
|
import { useTranslation } from "react-i18next";
|
|
import * as SubframeCore from "@subframe/core";
|
|
import { FeatherChevronDown, FeatherMoreHorizontal, FeatherPlus, FeatherTrash, FeatherUserCheck, FeatherUserX } from "@subframe/core";
|
|
import type { MembersListRow, MembersListVM } from "@hivegrid/view-models";
|
|
import { EMPTY_MEMBERS_FILTER, filterMembersRows, type MembersListFilterState, type MemberStatus } from "@hivegrid/view-models";
|
|
import { roleDisplayName } from "~/components/core/roles/roleDisplay";
|
|
import { Avatar } from "~/ui/components/Avatar";
|
|
import { BadgeFeedback } from "~/ui/components/BadgeFeedback";
|
|
import { Button } from "~/ui/components/Button";
|
|
import { Checkbox } from "~/ui/components/Checkbox";
|
|
import { Dialog } from "~/ui/components/Dialog";
|
|
import { DropdownMenu } from "~/ui/components/DropdownMenu";
|
|
import { EmptyState } from "~/ui/components/EmptyState";
|
|
import { IconButton } from "~/ui/components/IconButton";
|
|
import { SearchInput } from "~/ui/components/SearchInput";
|
|
import { Select } from "~/ui/components/Select";
|
|
import { Table } from "~/ui/components/Table";
|
|
import { Tabs } from "~/ui/components/Tabs";
|
|
|
|
// Non-empty sentinel for the "any" option (empty string is not a valid Select value).
|
|
const FILTER_ALL = "__all__";
|
|
const STATUS_OPTIONS: readonly MemberStatus[] = ["active", "invited", "inactive"];
|
|
|
|
export type MembersActions = {
|
|
/** Posts the existing `edit` intent (role add/remove) — D01 inline dropdown. */
|
|
onToggleRole: (input: { userId: string; roleId: string; add: boolean }) => void;
|
|
/** Posts the `deactivate` intent after the M03 confirm. */
|
|
onDeactivate: (input: { userId: string }) => void;
|
|
/** Posts the `reactivate` intent. */
|
|
onReactivate: (input: { userId: string }) => void;
|
|
/** Posts the existing `delete-invitation` intent. */
|
|
onDeleteInvitation: (input: { invitationId: string }) => void;
|
|
/** Opens the invite flow (M01 dialog route). */
|
|
onInvite: () => void;
|
|
};
|
|
|
|
export type MembersPageProps = {
|
|
vm: MembersListVM;
|
|
actions: MembersActions;
|
|
/** Tab bar between S01 (members) and S02 (roles & permissions), plus the D01 dropdown footer link. */
|
|
rolesTabHref: string | null;
|
|
/** Href of the member edit route (existing remove flow stays reachable). */
|
|
editRouteFor: (tenantUserId: string) => string;
|
|
/** True while a deactivate/reactivate submission is in flight. */
|
|
submitting: boolean;
|
|
/** Server said "last-admin" — opens the V01 blocker dialog. */
|
|
lastAdminBlocked: boolean;
|
|
};
|
|
|
|
export function MembersPage({ vm, actions, rolesTabHref, editRouteFor, submitting, lastAdminBlocked }: MembersPageProps) {
|
|
const { t } = useTranslation();
|
|
const [filter, setFilter] = useState<MembersListFilterState>(EMPTY_MEMBERS_FILTER);
|
|
const [deactivateRow, setDeactivateRow] = useState<MembersListRow | null>(null);
|
|
const [blockerDismissed, setBlockerDismissed] = useState(false);
|
|
|
|
// Server response (code "last-admin") re-opens the blocker; a new attempt resets the dismissal.
|
|
useEffect(() => {
|
|
if (lastAdminBlocked) setBlockerDismissed(false);
|
|
}, [lastAdminBlocked]);
|
|
|
|
// Close the confirm dialog when the pending submission finished.
|
|
useEffect(() => {
|
|
if (!submitting) setDeactivateRow(null);
|
|
}, [submitting]);
|
|
|
|
if (vm.status !== "ready" || !vm.data) {
|
|
return <div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.members.page" />;
|
|
}
|
|
|
|
const data = vm.data;
|
|
const rows = filterMembersRows(data.rows, filter);
|
|
const hasAnyRows = data.rows.length > 0 || data.pendingInvitations.length > 0;
|
|
|
|
return (
|
|
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.members.page">
|
|
{/* Header: title + description (0px rhythm) + invite CTA (M01) */}
|
|
<div className="flex flex-wrap items-start justify-between gap-4">
|
|
<div className="flex flex-col gap-0">
|
|
<span className="text-heading-2 font-heading-2 text-text-neutral-primary">{t("settings.members.title")}</span>
|
|
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
|
|
{t("settings.members.description")}
|
|
</span>
|
|
</div>
|
|
{data.canInvite ? (
|
|
<Button icon={<FeatherPlus />} onClick={actions.onInvite} data-ui-id="ui.settings.members.invite">
|
|
{t("settings.members.actions.new")}
|
|
</Button>
|
|
) : null}
|
|
</div>
|
|
|
|
{/* Tabs: Mitarbeiter | Rollen und Berechtigungen (David's S01 structure) */}
|
|
{rolesTabHref ? (
|
|
<Tabs>
|
|
<Tabs.Item active>{t("settings.members.tabs.members")}</Tabs.Item>
|
|
<Link to={rolesTabHref} className="contents no-underline" data-ui-id="ui.settings.members.tab.roles">
|
|
<Tabs.Item>{t("settings.members.tabs.rolesAndPermissions")}</Tabs.Item>
|
|
</Link>
|
|
</Tabs>
|
|
) : null}
|
|
|
|
{/* Toolbar: search (name/email/phone) + role/status/2FA filters */}
|
|
<div className="flex flex-wrap items-end gap-4" data-ui-id="ui.settings.members.search">
|
|
<SearchInput
|
|
className="max-w-[320px]"
|
|
placeholder={t("settings.members.filters.searchPlaceholder")}
|
|
hideShortcut
|
|
value={filter.query}
|
|
onChange={(event) => setFilter((prev) => ({ ...prev, query: event.target.value }))}
|
|
/>
|
|
<Select
|
|
className="max-w-[200px]"
|
|
label={t("settings.members.filters.role")}
|
|
showLabel
|
|
value={filter.roleId ?? FILTER_ALL}
|
|
onValueChange={(value: string) => setFilter((prev) => ({ ...prev, roleId: value === FILTER_ALL ? null : value }))}
|
|
>
|
|
<Select.Item value={FILTER_ALL}>{t("settings.members.filters.all")}</Select.Item>
|
|
{data.assignableRoles.map((role) => (
|
|
<Select.Item key={role.id} value={role.id}>
|
|
{roleDisplayName(role, t)}
|
|
</Select.Item>
|
|
))}
|
|
</Select>
|
|
<Select
|
|
className="max-w-[180px]"
|
|
label={t("settings.members.columns.status")}
|
|
showLabel
|
|
value={filter.status ?? FILTER_ALL}
|
|
onValueChange={(value: string) => setFilter((prev) => ({ ...prev, status: value === FILTER_ALL ? null : (value as MemberStatus) }))}
|
|
>
|
|
<Select.Item value={FILTER_ALL}>{t("settings.members.filters.all")}</Select.Item>
|
|
{STATUS_OPTIONS.map((status) => (
|
|
<Select.Item key={status} value={status}>
|
|
{t(`settings.members.status.${status === "inactive" ? "deactivated" : status}`)}
|
|
</Select.Item>
|
|
))}
|
|
</Select>
|
|
<Select
|
|
className="max-w-[160px]"
|
|
label={t("settings.members.columns.twoFactor")}
|
|
showLabel
|
|
value={filter.mfa === null ? FILTER_ALL : filter.mfa ? "on" : "off"}
|
|
onValueChange={(value: string) => setFilter((prev) => ({ ...prev, mfa: value === FILTER_ALL ? null : value === "on" }))}
|
|
>
|
|
<Select.Item value={FILTER_ALL}>{t("settings.members.filters.all")}</Select.Item>
|
|
<Select.Item value="on">{t("settings.members.twoFactor.on")}</Select.Item>
|
|
<Select.Item value="off">{t("settings.members.twoFactor.off")}</Select.Item>
|
|
</Select>
|
|
</div>
|
|
|
|
{!hasAnyRows ? (
|
|
<div data-ui-id="ui.settings.members.empty">
|
|
<EmptyState title={t(data.emptyHeadlineKey)} body={t(data.emptyBodyKey)} />
|
|
</div>
|
|
) : (
|
|
<div className="w-full overflow-x-auto" data-ui-id="ui.settings.members.table">
|
|
<Table
|
|
header={
|
|
<Table.HeaderRow>
|
|
<Table.HeaderCell>{t("models.user.object")}</Table.HeaderCell>
|
|
<Table.HeaderCell>{t("models.role.object")}</Table.HeaderCell>
|
|
<Table.HeaderCell>{t("settings.members.columns.status")}</Table.HeaderCell>
|
|
<Table.HeaderCell>{t("settings.members.columns.twoFactor")}</Table.HeaderCell>
|
|
<Table.HeaderCell> </Table.HeaderCell>
|
|
</Table.HeaderRow>
|
|
}
|
|
>
|
|
{rows.map((row) => (
|
|
<MemberRow
|
|
key={row.tenantUserId}
|
|
row={row}
|
|
data={data}
|
|
actions={actions}
|
|
editRouteFor={editRouteFor}
|
|
rolesTabHref={rolesTabHref}
|
|
onAskDeactivate={() => setDeactivateRow(row)}
|
|
/>
|
|
))}
|
|
{/* Invited users appear inline with status "Eingeladen" (David's S01). */}
|
|
{data.pendingInvitations.map((invitation) => (
|
|
<Table.Row key={invitation.id} data-ui-id="ui.settings.members.row">
|
|
<Table.Cell>
|
|
<div className="flex items-center gap-3">
|
|
<Avatar size="small">{invitation.email.charAt(0).toUpperCase()}</Avatar>
|
|
<div className="flex flex-col items-start">
|
|
<span className="whitespace-nowrap text-body-default-medium-0 font-body-default-medium-0 text-text-neutral-primary">
|
|
{invitation.name || invitation.email}
|
|
</span>
|
|
<span className="whitespace-nowrap text-body-small-regular-0 font-body-small-regular-0 text-text-neutral-tertiary">
|
|
{invitation.email}
|
|
</span>
|
|
</div>
|
|
</div>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<span className="text-body-default-regular-0 font-body-default-regular-0 text-text-neutral-subtle">—</span>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<BadgeFeedback farbe="subtle-warning">{t("settings.members.status.invited")}</BadgeFeedback>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<span className="text-body-default-regular-0 font-body-default-regular-0 text-text-neutral-subtle">—</span>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<div className="flex grow shrink-0 basis-0 items-center justify-end">
|
|
{data.canManageMembers ? (
|
|
<IconButton
|
|
icon={<FeatherTrash />}
|
|
title={t("shared.delete")}
|
|
onClick={() => actions.onDeleteInvitation({ invitationId: invitation.id })}
|
|
data-ui-id="ui.settings.members.invitation.delete"
|
|
/>
|
|
) : null}
|
|
</div>
|
|
</Table.Cell>
|
|
</Table.Row>
|
|
))}
|
|
{rows.length === 0 && data.pendingInvitations.length === 0 ? null : null}
|
|
</Table>
|
|
{rows.length === 0 && data.pendingInvitations.length === 0 ? (
|
|
<div className="pt-4" data-ui-id="ui.settings.members.noMatches">
|
|
<EmptyState title={t(data.noMatchesKey)} body={t(data.emptyBodyKey)} />
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
)}
|
|
|
|
{/* M03 — deactivate confirm (real Dialog, XS 420, danger action) */}
|
|
<Dialog open={deactivateRow !== null} onOpenChange={(open: boolean) => (open ? undefined : setDeactivateRow(null))}>
|
|
<Dialog.Content className="w-[420px] max-w-[90vw] p-4">
|
|
{deactivateRow ? (
|
|
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.members.deactivate.dialog">
|
|
<div className="flex flex-col gap-2">
|
|
<span className="text-heading-3 font-heading-3 text-text-neutral-primary">{t("settings.members.deactivate.title")}</span>
|
|
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
|
|
{deactivateRow.name} · {deactivateRow.email}
|
|
</span>
|
|
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
|
|
{t("settings.members.deactivate.body")}
|
|
</span>
|
|
<span className="text-body-small-regular-150 font-body-small-regular-150 text-text-neutral-tertiary">
|
|
{t("settings.members.deactivate.staysVisible")}
|
|
</span>
|
|
</div>
|
|
<div className="flex w-full items-center justify-end gap-2">
|
|
<Button variant="tertiary" onClick={() => setDeactivateRow(null)} data-ui-id="ui.settings.members.deactivate.cancel">
|
|
{t("shared.cancel")}
|
|
</Button>
|
|
<Button
|
|
variant="destructive"
|
|
loading={submitting}
|
|
onClick={() => actions.onDeactivate({ userId: deactivateRow.userId })}
|
|
data-ui-id="ui.settings.members.deactivate.confirm"
|
|
>
|
|
{t("settings.members.deactivate.confirm")}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : (
|
|
<div />
|
|
)}
|
|
</Dialog.Content>
|
|
</Dialog>
|
|
|
|
{/* V01 — last-admin blocker (server guard result, copy from David's wireframe) */}
|
|
<Dialog open={lastAdminBlocked && !blockerDismissed} onOpenChange={(open: boolean) => (open ? undefined : setBlockerDismissed(true))}>
|
|
<Dialog.Content className="w-[420px] max-w-[90vw] p-4">
|
|
<div className="flex w-full flex-col gap-6" data-ui-id="ui.settings.members.lastAdmin.dialog">
|
|
<div className="flex flex-col gap-2">
|
|
<span className="text-heading-3 font-heading-3 text-text-neutral-primary">{t("settings.members.errors.lastAdminTitle")}</span>
|
|
<span className="text-body-default-regular-150 font-body-default-regular-150 text-text-neutral-secondary">
|
|
{t("settings.members.errors.lastAdminBody")}
|
|
</span>
|
|
</div>
|
|
<div className="flex w-full items-center justify-end">
|
|
<Button onClick={() => setBlockerDismissed(true)} data-ui-id="ui.settings.members.lastAdmin.dismiss">
|
|
{t("settings.members.errors.lastAdminDismiss")}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</Dialog.Content>
|
|
</Dialog>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function MemberRow({
|
|
row,
|
|
data,
|
|
actions,
|
|
editRouteFor,
|
|
rolesTabHref,
|
|
onAskDeactivate,
|
|
}: {
|
|
row: MembersListRow;
|
|
data: NonNullable<MembersListVM["data"]>;
|
|
actions: MembersActions;
|
|
editRouteFor: (tenantUserId: string) => string;
|
|
rolesTabHref: string | null;
|
|
onAskDeactivate: () => void;
|
|
}) {
|
|
const { t } = useTranslation();
|
|
const roleLabels = row.roles.map((role) => roleDisplayName(role, t)).join(", ");
|
|
const assignedRoleIds = new Set(row.roles.map((role) => role.id));
|
|
const badge =
|
|
row.status === "active" ? ("subtle-positive" as const) : row.status === "inactive" ? ("subtle-neutral" as const) : ("subtle-warning" as const);
|
|
|
|
return (
|
|
<Table.Row data-ui-id="ui.settings.members.row">
|
|
<Table.Cell>
|
|
<div className="flex items-center gap-3">
|
|
<Avatar size="small">{row.initials}</Avatar>
|
|
<div className="flex flex-col items-start">
|
|
<span className="whitespace-nowrap text-body-default-medium-0 font-body-default-medium-0 text-text-neutral-primary">{row.name}</span>
|
|
<span className="whitespace-nowrap text-body-small-regular-0 font-body-small-regular-0 text-text-neutral-tertiary">
|
|
{row.email}
|
|
{row.phone ? ` · ${row.phone}` : ""}
|
|
</span>
|
|
</div>
|
|
</div>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
{/* D01 — inline role dropdown: checkbox item per role + link to S02 */}
|
|
{data.canEditRoles ? (
|
|
<SubframeCore.DropdownMenu.Root>
|
|
<SubframeCore.DropdownMenu.Trigger asChild>
|
|
<Button variant="tertiary" size="small" iconRight={<FeatherChevronDown />} data-ui-id="ui.settings.members.roleDropdown">
|
|
{roleLabels || t("settings.members.roles.none")}
|
|
</Button>
|
|
</SubframeCore.DropdownMenu.Trigger>
|
|
<SubframeCore.DropdownMenu.Portal>
|
|
<SubframeCore.DropdownMenu.Content side="bottom" align="start" sideOffset={4} asChild>
|
|
<DropdownMenu>
|
|
<div className="flex w-full flex-col items-start gap-2 px-3 py-2">
|
|
{data.assignableRoles.map((role) => (
|
|
<Checkbox
|
|
key={role.id}
|
|
label={roleDisplayName(role, t)}
|
|
checked={assignedRoleIds.has(role.id)}
|
|
onCheckedChange={(checked: boolean) => actions.onToggleRole({ userId: row.userId, roleId: role.id, add: checked })}
|
|
/>
|
|
))}
|
|
{/* D01 footer entry: jump to S02 ("Rollen und Berechtigungen bearbeiten"). */}
|
|
{rolesTabHref ? (
|
|
<Link to={rolesTabHref} className="no-underline" data-ui-id="ui.settings.members.roleDropdown.editRoles">
|
|
<span className="text-body-small-regular-0 font-body-small-regular-0 text-brand-brand-text-solid-default">
|
|
{t("settings.members.roles.editRolesLink")}
|
|
</span>
|
|
</Link>
|
|
) : null}
|
|
</div>
|
|
</DropdownMenu>
|
|
</SubframeCore.DropdownMenu.Content>
|
|
</SubframeCore.DropdownMenu.Portal>
|
|
</SubframeCore.DropdownMenu.Root>
|
|
) : (
|
|
<span className="whitespace-nowrap text-body-default-regular-0 font-body-default-regular-0 text-text-neutral-secondary">
|
|
{roleLabels || "—"}
|
|
</span>
|
|
)}
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<BadgeFeedback farbe={badge}>{t(row.statusLabelKey)}</BadgeFeedback>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<BadgeFeedback farbe={row.mfaEnabled ? "subtle-positive" : "subtle-neutral"}>
|
|
{row.mfaEnabled ? t("settings.members.twoFactor.on") : t("settings.members.twoFactor.off")}
|
|
</BadgeFeedback>
|
|
</Table.Cell>
|
|
<Table.Cell>
|
|
<div className="flex grow shrink-0 basis-0 items-center justify-end">
|
|
{data.canManageMembers || data.canEditRoles ? (
|
|
<SubframeCore.DropdownMenu.Root>
|
|
<SubframeCore.DropdownMenu.Trigger asChild>
|
|
<IconButton icon={<FeatherMoreHorizontal />} data-ui-id="ui.settings.members.rowActions" />
|
|
</SubframeCore.DropdownMenu.Trigger>
|
|
<SubframeCore.DropdownMenu.Portal>
|
|
<SubframeCore.DropdownMenu.Content side="bottom" align="end" sideOffset={4} asChild>
|
|
<DropdownMenu>
|
|
{row.canDeactivate ? (
|
|
<DropdownMenu.DropdownItem icon={<FeatherUserX />} onClick={onAskDeactivate} data-ui-id="ui.settings.members.menu.deactivate">
|
|
{t("settings.members.menu.deactivate")}
|
|
</DropdownMenu.DropdownItem>
|
|
) : null}
|
|
{row.canReactivate ? (
|
|
<DropdownMenu.DropdownItem
|
|
icon={<FeatherUserCheck />}
|
|
onClick={() => actions.onReactivate({ userId: row.userId })}
|
|
data-ui-id="ui.settings.members.menu.reactivate"
|
|
>
|
|
{t("settings.members.menu.reactivate")}
|
|
</DropdownMenu.DropdownItem>
|
|
) : null}
|
|
{data.canManageMembers ? (
|
|
<Link to={editRouteFor(row.tenantUserId)} className="no-underline">
|
|
<DropdownMenu.DropdownItem icon={<FeatherTrash />}>{t("settings.members.menu.remove")}</DropdownMenu.DropdownItem>
|
|
</Link>
|
|
) : null}
|
|
</DropdownMenu>
|
|
</SubframeCore.DropdownMenu.Content>
|
|
</SubframeCore.DropdownMenu.Portal>
|
|
</SubframeCore.DropdownMenu.Root>
|
|
) : null}
|
|
</div>
|
|
</Table.Cell>
|
|
</Table.Row>
|
|
);
|
|
}
|