227 lines
11 KiB
TypeScript
227 lines
11 KiB
TypeScript
// @vitest-environment node
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { ActionFunctionArgs } from "react-router";
|
|
|
|
vi.mock("react-i18next", () => ({
|
|
useTranslation: () => ({ t: (key: string) => key }),
|
|
}));
|
|
vi.mock("react-router", async () => {
|
|
const actual = await vi.importActual<typeof import("react-router")>("react-router");
|
|
return {
|
|
...actual,
|
|
Link: () => null,
|
|
useActionData: () => undefined,
|
|
useLoaderData: () => ({}),
|
|
useNavigate: () => vi.fn(),
|
|
useOutlet: () => null,
|
|
};
|
|
});
|
|
vi.mock("react-hot-toast", () => ({ default: { success: vi.fn() } }));
|
|
vi.mock("~/utils/app/CanonicalUrlUtils", () => ({
|
|
appPath: ({ tenantSlug, path }: { tenantSlug: string; path?: string }) => (path ? `/${tenantSlug}/${path}` : `/${tenantSlug}`),
|
|
adminPath: (path?: string | { mode?: string; path?: string }, options?: { mode?: string }) => {
|
|
const inputPath = typeof path === "object" ? path.path : path;
|
|
const mode = typeof path === "object" ? path.mode : options?.mode;
|
|
const normalizedPath = inputPath ? `/${inputPath.replace(/^\/+/, "")}` : "";
|
|
return mode === "legacy" ? `/admin${normalizedPath}` : normalizedPath || "/";
|
|
},
|
|
}));
|
|
vi.mock("~/utils/app/HostRouting.server", () => ({
|
|
getHostRoutingContextFromRequest: vi.fn(() => "admin"),
|
|
}));
|
|
vi.mock("@hivegrid/config", () => ({
|
|
loadRequiredWebConfig: () => ({ routing: undefined }),
|
|
}));
|
|
vi.mock("~/components/core/users/UsersTable", () => ({ default: () => null }));
|
|
vi.mock("~/components/ui/button", () => ({ Button: () => null }));
|
|
vi.mock("~/components/ui/input/InputFilters", () => ({ default: () => null }));
|
|
vi.mock("~/components/ui/layouts/EditPageLayout", () => ({ default: () => null }));
|
|
vi.mock("~/components/ui/slideOvers/SlideOverWideEmpty", () => ({ default: () => null }));
|
|
vi.mock("~/modules/events/services/.server/EventsService", () => ({ default: { create: vi.fn() } }));
|
|
vi.mock("~/modules/metrics/services/.server/MetricTracker", () => ({ createMetrics: vi.fn() }));
|
|
vi.mock("~/modules/metrics/utils/defaultHeaders", () => ({ serverTimingHeaders: vi.fn() }));
|
|
vi.mock("~/utils/data/useAdminData", () => ({ useAdminData: () => ({}) }));
|
|
vi.mock("~/utils/db/logs.db.server", () => ({ getLastUserLog: vi.fn() }));
|
|
vi.mock("~/utils/helpers/PermissionsHelper", () => ({ getUserHasPermission: vi.fn() }));
|
|
vi.mock("~/utils/helpers/RowPaginationHelper", () => ({
|
|
getFiltersFromCurrentUrl: vi.fn(),
|
|
getPaginationFromCurrentUrl: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/services/userService", () => ({ deleteUserWithItsTenants: vi.fn() }));
|
|
vi.mock("~/locale/i18next.server", () => ({
|
|
getTranslations: vi.fn(async () => ({ t: (key: string) => key })),
|
|
}));
|
|
vi.mock("~/utils/auth/mfa/enforcement.server", () => ({
|
|
enforceAdminMfa: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/auth/mfa/step-up.server", () => ({
|
|
checkMfaStepUpState: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/db/tenants.db.server", () => ({
|
|
adminGetAllTenantsIdsAndNames: vi.fn(),
|
|
getTenant: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/db/users.db.server", () => ({
|
|
adminGetAllUsers: vi.fn(),
|
|
getUser: vi.fn(),
|
|
getUserTotpStatus: vi.fn(),
|
|
updateUserPassword: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/helpers/.server/PermissionsService", () => ({
|
|
verifyUserHasPermission: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/session.server", () => ({
|
|
createImpersonationStartedAt: vi.fn(() => "2026-05-08T17:00:00.000Z"),
|
|
createUserSession: vi.fn(),
|
|
getUserInfo: vi.fn(),
|
|
getUserSession: vi.fn(),
|
|
setLoggedUser: vi.fn(),
|
|
validateCSRFToken: vi.fn(),
|
|
}));
|
|
vi.mock("@hivegrid/db/impersonation-audit.server", () => ({
|
|
createImpersonationAudit: vi.fn(),
|
|
}));
|
|
vi.mock("@hivegrid/db/audit-events.server", () => ({
|
|
createAuditEvent: vi.fn(),
|
|
}));
|
|
|
|
import { createImpersonationAudit } from "@hivegrid/db/impersonation-audit.server";
|
|
import { enforceAdminMfa } from "~/utils/auth/mfa/enforcement.server";
|
|
import { checkMfaStepUpState } from "~/utils/auth/mfa/step-up.server";
|
|
import { getTenant } from "~/utils/db/tenants.db.server";
|
|
import { getUser, getUserTotpStatus, updateUserPassword } from "~/utils/db/users.db.server";
|
|
import { verifyUserHasPermission } from "~/utils/helpers/.server/PermissionsService";
|
|
import { deleteUserWithItsTenants } from "~/utils/services/userService";
|
|
import { createUserSession, getUserInfo, getUserSession, setLoggedUser, validateCSRFToken } from "~/utils/session.server";
|
|
import { action } from "./users";
|
|
|
|
const actor = { id: "admin-1", admin: true, email: "admin@example.test" };
|
|
const targetUser = { id: "user-1", admin: false, email: "user@example.test", defaultTenantId: "tenant-1" };
|
|
const actorInfo = {
|
|
userId: actor.id,
|
|
lightOrDarkMode: "light",
|
|
lng: "en",
|
|
cookies: [],
|
|
};
|
|
const enabledTotpStatus = { enabled: true, pending: false, enabledAt: new Date("2026-05-08T12:00:00.000Z"), pendingCreatedAt: null };
|
|
const freshStepUp = { verified: true, state: { userId: actor.id, method: "totp", verifiedAt: "2026-05-08T16:59:00.000Z" }, ageMs: 60_000 };
|
|
|
|
function postRequest(actionName = "impersonate", extra: Record<string, string> = {}) {
|
|
return new Request("https://admin.example.test/accounts/users?filter=active", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/x-www-form-urlencoded" },
|
|
body: new URLSearchParams({ action: actionName, "user-id": targetUser.id, ...extra }),
|
|
});
|
|
}
|
|
|
|
async function callAction(actionName = "impersonate", extra: Record<string, string> = {}) {
|
|
try {
|
|
const response = await action({ request: postRequest(actionName, extra), params: {}, context: {}, unstable_pattern: "admin/accounts/users" } as ActionFunctionArgs);
|
|
return { thrown: false, response: response as Response };
|
|
} catch (error) {
|
|
return { thrown: true, response: await (error as Promise<Response>) };
|
|
}
|
|
}
|
|
|
|
describe("admin accounts user impersonation MFA guard", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
vi.mocked(verifyUserHasPermission).mockResolvedValue(undefined as never);
|
|
vi.mocked(validateCSRFToken).mockResolvedValue(undefined as never);
|
|
vi.mocked(getUserInfo).mockResolvedValue(actorInfo as never);
|
|
vi.mocked(getUserSession).mockResolvedValue({ get: vi.fn() } as never);
|
|
vi.mocked(getUser).mockImplementation(async (id?: string) => (id === actor.id || id === undefined ? actor : id === targetUser.id ? targetUser : null) as never);
|
|
vi.mocked(getUserTotpStatus).mockResolvedValue(enabledTotpStatus as never);
|
|
vi.mocked(checkMfaStepUpState).mockReturnValue(freshStepUp as never);
|
|
vi.mocked(enforceAdminMfa).mockImplementation(() => ({ allowed: true, reason: "allowed", redirectTo: "/accounts/users" }) as never);
|
|
vi.mocked(setLoggedUser).mockResolvedValue({ userId: targetUser.id, defaultTenantId: "tenant-1" } as never);
|
|
vi.mocked(getTenant).mockResolvedValue({ id: "tenant-1", slug: "acme" } as never);
|
|
vi.mocked(updateUserPassword).mockResolvedValue({} as never);
|
|
vi.mocked(deleteUserWithItsTenants).mockResolvedValue({ deletedTenants: [] } as never);
|
|
vi.mocked(createImpersonationAudit).mockResolvedValue({
|
|
id: "audit-1",
|
|
createdAt: new Date("2026-05-08T17:00:00.000Z"),
|
|
actorUserId: actor.id,
|
|
targetUserId: targetUser.id,
|
|
tenantId: "tenant-1",
|
|
action: "start",
|
|
reason: "admin.users.impersonate",
|
|
requestPath: "/accounts/users",
|
|
metadata: null,
|
|
} as never);
|
|
vi.mocked(createUserSession).mockResolvedValue(new Response(null, { status: 302, headers: { Location: "/acme/dashboard" } }) as never);
|
|
});
|
|
|
|
it("requires fresh admin MFA step-up before creating an impersonation session", async () => {
|
|
const result = await callAction();
|
|
|
|
expect(result.thrown).toBe(false);
|
|
expect(result.response).toBeDefined();
|
|
expect(validateCSRFToken).toHaveBeenCalledWith(expect.any(Request));
|
|
expect(verifyUserHasPermission).toHaveBeenCalledWith(expect.any(Request), "admin.users.impersonate");
|
|
expect(getUserTotpStatus).toHaveBeenCalledWith(actor.id);
|
|
expect(checkMfaStepUpState).toHaveBeenCalledWith(expect.anything(), actor.id);
|
|
expect(enforceAdminMfa).toHaveBeenCalledWith(expect.objectContaining({
|
|
requestUrl: "https://admin.example.test/accounts/users?filter=active",
|
|
userId: actor.id,
|
|
isAdmin: true,
|
|
totpStatus: enabledTotpStatus,
|
|
stepUp: freshStepUp,
|
|
redirectMode: "host-aware",
|
|
}));
|
|
expect(setLoggedUser).toHaveBeenCalledWith(targetUser);
|
|
expect(getTenant).toHaveBeenCalledWith("tenant-1");
|
|
expect(result.response.headers.get("Location")).toBe("/acme/dashboard");
|
|
});
|
|
|
|
it("redirects to the MFA challenge and does not switch sessions when step-up is missing", async () => {
|
|
vi.mocked(checkMfaStepUpState).mockReturnValue({ verified: false, reason: "missing" } as never);
|
|
vi.mocked(enforceAdminMfa).mockReturnValue({
|
|
allowed: false,
|
|
reason: "step-up-missing",
|
|
redirectTo: "/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive",
|
|
} as never);
|
|
|
|
const result = await callAction();
|
|
|
|
expect(result.thrown).toBe(true);
|
|
expect(result.response.status).toBe(302);
|
|
expect(result.response.headers.get("Location")).toBe("/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive");
|
|
expect(setLoggedUser).not.toHaveBeenCalled();
|
|
expect(createImpersonationAudit).not.toHaveBeenCalled();
|
|
expect(createUserSession).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("requires fresh admin MFA before changing a user password", async () => {
|
|
vi.mocked(checkMfaStepUpState).mockReturnValue({ verified: false, reason: "missing" } as never);
|
|
vi.mocked(enforceAdminMfa).mockReturnValue({
|
|
allowed: false,
|
|
reason: "step-up-missing",
|
|
redirectTo: "/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive",
|
|
} as never);
|
|
|
|
const result = await callAction("change-password", { "password-new": "new-password-123" });
|
|
|
|
expect(result.thrown).toBe(true);
|
|
expect(result.response.status).toBe(302);
|
|
expect(result.response.headers.get("Location")).toBe("/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive");
|
|
expect(updateUserPassword).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("requires fresh admin MFA before deleting a user", async () => {
|
|
vi.mocked(checkMfaStepUpState).mockReturnValue({ verified: false, reason: "missing" } as never);
|
|
vi.mocked(enforceAdminMfa).mockReturnValue({
|
|
allowed: false,
|
|
reason: "step-up-missing",
|
|
redirectTo: "/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive",
|
|
} as never);
|
|
|
|
const result = await callAction("delete-user");
|
|
|
|
expect(result.thrown).toBe(true);
|
|
expect(result.response.status).toBe(302);
|
|
expect(result.response.headers.get("Location")).toBe("/mfa-challenge?redirectTo=%2Faccounts%2Fusers%3Ffilter%3Dactive");
|
|
expect(deleteUserWithItsTenants).not.toHaveBeenCalled();
|
|
});
|
|
});
|