212 lines
9.8 KiB
TypeScript
212 lines
9.8 KiB
TypeScript
// @vitest-environment node
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { ActionFunctionArgs } from "react-router";
|
|
|
|
vi.mock("~/locale/i18next.server", () => ({ getTranslations: vi.fn() }));
|
|
vi.mock("~/utils/session.server", () => ({ getUserInfo: vi.fn(), validateCSRFToken: vi.fn() }));
|
|
vi.mock("~/utils/services/.server/urlService", () => ({ getTenantIdFromUrl: vi.fn() }));
|
|
vi.mock("~/utils/helpers/.server/PermissionsService", () => ({ verifyUserHasPermission: vi.fn() }));
|
|
vi.mock("~/utils/db/users.db.server", () => ({ getUser: vi.fn() }));
|
|
vi.mock("~/utils/db/tenants.db.server", () => ({
|
|
getTenant: vi.fn(),
|
|
getTenantBySlug: vi.fn(),
|
|
updateTenant: vi.fn(),
|
|
}));
|
|
vi.mock("~/utils/db/logs.db.server", () => ({ createLog: vi.fn() }));
|
|
vi.mock("~/utils/db/entities/entities.db.server", () => ({ findEntityByName: vi.fn() }));
|
|
vi.mock("~/utils/api/.server/RowsApi", () => ({ RowsApi: { createCustom: vi.fn() } }));
|
|
vi.mock("~/utils/integrations/storageService", () => ({ storeFile: vi.fn() }));
|
|
vi.mock("~/utils/integrations/storageAudit.server", () => ({ auditRejectedUpload: vi.fn(() => vi.fn()) }));
|
|
vi.mock("~/modules/events/services/.server/EventsService", () => ({ default: { create: vi.fn() } }));
|
|
vi.mock("~/utils/services/tenantService", () => ({
|
|
deleteAndCancelTenant: vi.fn(),
|
|
isReservedTenantSlug: vi.fn(),
|
|
normalizeTenantSlug: vi.fn((value: string) => value.trim().toLowerCase()),
|
|
}));
|
|
vi.mock("~/utils/services/.server/subscriptionService", () => ({ getActiveTenantSubscriptions: vi.fn() }));
|
|
vi.mock("~/utils/db/tenants/tenantTypes.db.server", () => ({ getTenantTypeOptions: vi.fn() }));
|
|
vi.mock("@toolctrl/config", () => ({ loadRequiredWebConfig: vi.fn(() => ({ routing: { mode: "path" } })) }));
|
|
|
|
import EventsService from "~/modules/events/services/.server/EventsService";
|
|
import { getTranslations } from "~/locale/i18next.server";
|
|
import { createLog } from "~/utils/db/logs.db.server";
|
|
import { getTenant, getTenantBySlug, updateTenant } from "~/utils/db/tenants.db.server";
|
|
import { findEntityByName } from "~/utils/db/entities/entities.db.server";
|
|
import { getUser } from "~/utils/db/users.db.server";
|
|
import { RowsApi } from "~/utils/api/.server/RowsApi";
|
|
import { storeFile } from "~/utils/integrations/storageService";
|
|
import { deleteAndCancelTenant, isReservedTenantSlug } from "~/utils/services/tenantService";
|
|
import { getActiveTenantSubscriptions } from "~/utils/services/.server/subscriptionService";
|
|
import { verifyUserHasPermission } from "~/utils/helpers/.server/PermissionsService";
|
|
import { getTenantIdFromUrl } from "~/utils/services/.server/urlService";
|
|
import { getUserInfo, validateCSRFToken } from "~/utils/session.server";
|
|
import { action } from "./account";
|
|
|
|
const params = { tenant: "acme" };
|
|
const user = { id: "user_1", email: "ada@example.test" };
|
|
const tenant = {
|
|
id: "tenant_1",
|
|
name: "Acme",
|
|
slug: "acme",
|
|
icon: null,
|
|
tenantSettingsRow: null,
|
|
};
|
|
|
|
function createRequest(form: FormData) {
|
|
return new Request("https://app.example.test/acme/settings/account", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/x-www-form-urlencoded" },
|
|
body: new URLSearchParams(Array.from(form.entries()).map(([key, value]) => [key, String(value)])),
|
|
});
|
|
}
|
|
|
|
function createEditForm(overrides: Record<string, string> = {}) {
|
|
const form = new FormData();
|
|
form.set("action", "edit");
|
|
form.set("name", "Acme GmbH");
|
|
form.set("slug", "acme");
|
|
form.set("icon", "");
|
|
for (const [key, value] of Object.entries(overrides)) {
|
|
form.set(key, value);
|
|
}
|
|
return form;
|
|
}
|
|
|
|
function createDeleteForm() {
|
|
const form = new FormData();
|
|
form.set("action", "delete");
|
|
return form;
|
|
}
|
|
|
|
async function callAction(form: FormData) {
|
|
return action({
|
|
request: createRequest(form),
|
|
params,
|
|
context: {},
|
|
unstable_pattern: "app.$tenant/settings/account",
|
|
} as ActionFunctionArgs) as Promise<Response>;
|
|
}
|
|
|
|
describe("tenant account settings action", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
vi.mocked(getTranslations).mockResolvedValue({
|
|
t: (key: string, values?: Record<string, unknown>) => (values?.slug ? `${key}:${values.slug}` : key),
|
|
} as never);
|
|
vi.mocked(validateCSRFToken).mockResolvedValue(undefined as never);
|
|
vi.mocked(getUserInfo).mockResolvedValue({ userId: user.id } as never);
|
|
vi.mocked(getUser).mockResolvedValue(user as never);
|
|
vi.mocked(getTenantIdFromUrl).mockResolvedValue(tenant.id);
|
|
vi.mocked(verifyUserHasPermission).mockResolvedValue(undefined as never);
|
|
vi.mocked(getTenant).mockResolvedValue(tenant as never);
|
|
vi.mocked(getTenantBySlug).mockResolvedValue(null as never);
|
|
vi.mocked(findEntityByName).mockResolvedValue(null as never);
|
|
vi.mocked(updateTenant).mockResolvedValue({ ...tenant, name: "Acme GmbH" } as never);
|
|
vi.mocked(EventsService.create).mockResolvedValue(undefined as never);
|
|
vi.mocked(createLog).mockResolvedValue({} as never);
|
|
vi.mocked(storeFile).mockImplementation(async ({ content }) => String(content));
|
|
vi.mocked(isReservedTenantSlug).mockReturnValue(false);
|
|
vi.mocked(RowsApi.createCustom).mockResolvedValue({} as never);
|
|
vi.mocked(getActiveTenantSubscriptions).mockResolvedValue({ products: [] } as never);
|
|
vi.mocked(deleteAndCancelTenant).mockResolvedValue(undefined as never);
|
|
});
|
|
|
|
it("updates account details without changing slug and records audit side effects", async () => {
|
|
const response = await callAction(createEditForm());
|
|
const data = await response.json();
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(data).toEqual({ success: "settings.tenant.updated" });
|
|
expect(verifyUserHasPermission).toHaveBeenCalledWith(expect.any(Request), "app.settings.account.update", tenant.id);
|
|
expect(createLog).toHaveBeenCalledWith(expect.any(Request), tenant.id, "settings.tenant.updateDetails", JSON.stringify({ name: "Acme GmbH", slug: "acme" }));
|
|
expect(updateTenant).toHaveBeenCalledWith(tenant, { name: "Acme GmbH", icon: "", slug: "acme" });
|
|
expect(EventsService.create).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
event: "account.updated",
|
|
tenantId: tenant.id,
|
|
userId: user.id,
|
|
})
|
|
);
|
|
expect(getTenantBySlug).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("redirects to the new tenant route when the slug changes", async () => {
|
|
const response = await callAction(createEditForm({ slug: "new-acme" }));
|
|
|
|
expect(response.status).toBe(302);
|
|
expect(response.headers.get("Location")).toBe("/new-acme/settings/account");
|
|
expect(getTenantBySlug).toHaveBeenCalledWith("new-acme");
|
|
expect(updateTenant).toHaveBeenCalledWith(tenant, { name: "Acme GmbH", icon: "", slug: "new-acme" });
|
|
});
|
|
|
|
it("rejects duplicate slugs before mutating the tenant or publishing events", async () => {
|
|
vi.mocked(getTenantBySlug).mockResolvedValueOnce({ id: "tenant_2", slug: "new-acme" } as never);
|
|
|
|
const response = await callAction(createEditForm({ slug: "new-acme" }));
|
|
const data = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(data).toEqual({ updateDetailsError: "settings.tenant.errors.slugTaken" });
|
|
expect(updateTenant).not.toHaveBeenCalled();
|
|
expect(EventsService.create).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("rejects reserved slugs before logs, row properties, storage, and tenant mutation", async () => {
|
|
vi.mocked(isReservedTenantSlug).mockReturnValueOnce(true);
|
|
|
|
const response = await callAction(createEditForm({ slug: "admin" }));
|
|
const data = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(data).toEqual({ updateDetailsError: "settings.tenant.errors.reservedSlug:admin" });
|
|
expect(createLog).not.toHaveBeenCalled();
|
|
expect(RowsApi.createCustom).not.toHaveBeenCalled();
|
|
expect(storeFile).not.toHaveBeenCalled();
|
|
expect(updateTenant).not.toHaveBeenCalled();
|
|
expect(EventsService.create).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("keeps tenant settings row internals out of update errors", async () => {
|
|
vi.mocked(findEntityByName).mockResolvedValueOnce({ id: "entity_1" } as never);
|
|
vi.mocked(RowsApi.createCustom).mockRejectedValueOnce(new Error("raw row settings failure"));
|
|
const consoleError = vi.spyOn(console, "error").mockImplementation(() => undefined);
|
|
|
|
const response = await callAction(createEditForm());
|
|
const data = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(data).toEqual({ updateDetailsError: "shared.unexpectedError" });
|
|
expect(JSON.stringify(data)).not.toContain("raw row settings failure");
|
|
expect(consoleError).toHaveBeenCalledWith(expect.any(Error));
|
|
consoleError.mockRestore();
|
|
});
|
|
|
|
it("stops on CSRF failure before permission checks and mutations", async () => {
|
|
const csrfError = new Response("csrf", { status: 403 });
|
|
vi.mocked(validateCSRFToken).mockRejectedValueOnce(csrfError as never);
|
|
|
|
await expect(callAction(createEditForm())).rejects.toBe(csrfError);
|
|
|
|
expect(getUserInfo).not.toHaveBeenCalled();
|
|
expect(getTenantIdFromUrl).not.toHaveBeenCalled();
|
|
expect(verifyUserHasPermission).not.toHaveBeenCalled();
|
|
expect(updateTenant).not.toHaveBeenCalled();
|
|
expect(EventsService.create).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("rejects account deletion with active subscriptions before delete side effects", async () => {
|
|
vi.mocked(getActiveTenantSubscriptions).mockResolvedValueOnce({
|
|
products: [{ id: "subscription_product_1", cancelledAt: null }],
|
|
} as never);
|
|
|
|
const response = await callAction(createDeleteForm());
|
|
const data = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(data).toEqual({ deleteError: "settings.tenant.errors.cannotDeleteWithActiveSubscriptions" });
|
|
expect(verifyUserHasPermission).toHaveBeenCalledWith(expect.any(Request), "app.settings.account.delete", tenant.id);
|
|
expect(deleteAndCancelTenant).not.toHaveBeenCalled();
|
|
expect(EventsService.create).not.toHaveBeenCalledWith(expect.objectContaining({ event: "account.deleted" }));
|
|
});
|
|
});
|