129 lines
5.1 KiB
TypeScript
129 lines
5.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { extractAdminSsoClaims, hasAllowedAdminGroup, isAllowedAdminGroup } from "./claims.server";
|
|
|
|
describe("isAllowedAdminGroup / hasAllowedAdminGroup", () => {
|
|
it("recognizes the two allowlisted groups", () => {
|
|
expect(isAllowedAdminGroup("hivegrid-admin")).toBe(true);
|
|
expect(isAllowedAdminGroup("hivegrid-staff")).toBe(true);
|
|
expect(isAllowedAdminGroup("hivegrid-rando")).toBe(false);
|
|
});
|
|
|
|
it("returns false when claim list has no allowed group", () => {
|
|
expect(hasAllowedAdminGroup(["other"])).toBe(false);
|
|
expect(hasAllowedAdminGroup([])).toBe(false);
|
|
expect(hasAllowedAdminGroup(undefined)).toBe(false);
|
|
});
|
|
|
|
it("returns true when at least one allowed group is present", () => {
|
|
expect(hasAllowedAdminGroup(["other", "hivegrid-staff"])).toBe(true);
|
|
});
|
|
|
|
it("treats both allowed groups identically as access gates", () => {
|
|
expect(hasAllowedAdminGroup(["hivegrid-admin"])).toBe(true);
|
|
expect(hasAllowedAdminGroup(["hivegrid-staff"])).toBe(true);
|
|
expect(hasAllowedAdminGroup(["hivegrid-staff", "hivegrid-admin"])).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("extractAdminSsoClaims", () => {
|
|
const validClaims = {
|
|
sub: "auth-uid-123",
|
|
email: "Admin@Example.test",
|
|
email_verified: true,
|
|
name: "Admin Person",
|
|
groups: ["hivegrid-admin"],
|
|
amr: ["pwd", "mfa"],
|
|
};
|
|
|
|
it("extracts and normalizes a valid claim set", () => {
|
|
const result = extractAdminSsoClaims(validClaims);
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(result.claims.subject).toBe("auth-uid-123");
|
|
expect(result.claims.email).toBe("admin@example.test");
|
|
expect(result.claims.name).toBe("Admin Person");
|
|
expect(result.claims.groups).toEqual(["hivegrid-admin"]);
|
|
expect(result.claims.emailVerified).toBe(true);
|
|
expect(result.claims.authenticationMethods).toEqual(["pwd", "mfa"]);
|
|
}
|
|
});
|
|
|
|
it("falls back to preferred_username when name is missing", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, name: undefined, preferred_username: "admin-handle" });
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.claims.name).toBe("admin-handle");
|
|
});
|
|
|
|
it("falls back to email when both name and preferred_username are missing", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, name: undefined });
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.claims.name).toBe("admin@example.test");
|
|
});
|
|
|
|
it("rejects missing sub", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, sub: undefined });
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("missing-sub");
|
|
});
|
|
|
|
it("rejects missing email", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, email: "" });
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("missing-email");
|
|
});
|
|
|
|
it("rejects email_verified=false", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, email_verified: false });
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("email-not-verified");
|
|
});
|
|
|
|
it("rejects a missing email_verified claim", () => {
|
|
const claims = { ...validClaims } as Record<string, unknown>;
|
|
delete claims.email_verified;
|
|
const result = extractAdminSsoClaims(claims);
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("email-not-verified");
|
|
});
|
|
|
|
it("rejects malformed truthy email_verified claims", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, email_verified: "true" });
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("email-not-verified");
|
|
});
|
|
|
|
it("filters non-string entries from groups", () => {
|
|
const result = extractAdminSsoClaims({ ...validClaims, groups: ["hivegrid-admin", null, 7, "ok"] });
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.claims.groups).toEqual(["hivegrid-admin", "ok"]);
|
|
});
|
|
|
|
it("canonicalizes duplicate groups emitted by overlapping Authentik scope mappings", () => {
|
|
const result = extractAdminSsoClaims({
|
|
...validClaims,
|
|
groups: ["authentik Admins", "sogo-users", "hivegrid-admin", "authentik Admins", "sogo-users", "hivegrid-admin"],
|
|
});
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(result.claims.groups).toEqual(["authentik Admins", "sogo-users", "hivegrid-admin"]);
|
|
}
|
|
});
|
|
|
|
it("extracts only string authentication methods and defaults missing amr to an empty list", () => {
|
|
const filtered = extractAdminSsoClaims({ ...validClaims, amr: ["pwd", null, 7, "mfa"] });
|
|
expect(filtered.ok).toBe(true);
|
|
if (filtered.ok) expect(filtered.claims.authenticationMethods).toEqual(["pwd", "mfa"]);
|
|
|
|
const missing = extractAdminSsoClaims({ ...validClaims, amr: undefined });
|
|
expect(missing.ok).toBe(true);
|
|
if (missing.ok) expect(missing.claims.authenticationMethods).toEqual([]);
|
|
});
|
|
|
|
it("returns missing-sub for null claims", () => {
|
|
const result = extractAdminSsoClaims(null);
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.reason).toBe("missing-sub");
|
|
});
|
|
});
|