55 lines
2.9 KiB
TypeScript
55 lines
2.9 KiB
TypeScript
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { describe, expect, test } from "vitest";
|
|
import { resolveRepoPath } from "~/utils/testing/repoPaths";
|
|
|
|
// AK-P16b · static authorization-boundary guard for the booking mutation routes
|
|
// (DoD A.5 / DoD 6). Asserts every state-changing action runs the module/permission
|
|
// guard, the owner-check (where applicable) and CSRF validation BEFORE it reads the
|
|
// form body — so a missing module/permission/owner/CSRF can never reach a mutation.
|
|
|
|
const appRoot = resolveRepoPath("apps/web/app");
|
|
|
|
describe("booking route authorization boundary", () => {
|
|
test("appointment detail action guards permission + CSRF + owner before parsing the form", () => {
|
|
const source = fs.readFileSync(path.join(appRoot, "routes/app.$tenant/bookings.$id.tsx"), "utf8");
|
|
const formDataAt = source.indexOf("await request.formData()");
|
|
expect(formDataAt).toBeGreaterThanOrEqual(0);
|
|
|
|
const permissionAt = source.indexOf("requireBookingPermission(ctx, BOOKING_PERMISSIONS.readOwn)", source.indexOf("export const action"));
|
|
const csrfAt = source.indexOf("await validateCSRFToken(request)");
|
|
const ownerAt = source.indexOf("requireAppointmentOwner(ctx, appt.providerUserId)", source.indexOf("export const action"));
|
|
|
|
expect(permissionAt).toBeGreaterThanOrEqual(0);
|
|
expect(csrfAt).toBeGreaterThanOrEqual(0);
|
|
expect(ownerAt).toBeGreaterThanOrEqual(0);
|
|
expect(permissionAt).toBeLessThan(formDataAt);
|
|
expect(csrfAt).toBeLessThan(formDataAt);
|
|
expect(ownerAt).toBeLessThan(formDataAt);
|
|
});
|
|
|
|
test("appointment detail mutation intents use write/admin permissions for lifecycle changes", () => {
|
|
const source = fs.readFileSync(path.join(appRoot, "routes/app.$tenant/bookings.$id.tsx"), "utf8");
|
|
|
|
expect(source).toContain("rescheduleAppointment");
|
|
expect(source).toContain("reassignAppointment");
|
|
expect(source.match(/requireBookingPermission\(ctx, BOOKING_PERMISSIONS\.write\)/g)?.length ?? 0).toBeGreaterThanOrEqual(4);
|
|
expect(source).toContain("requireBookingPermission(ctx, BOOKING_PERMISSIONS.admin)");
|
|
expect(source).toContain('intent === "reschedule"');
|
|
expect(source).toContain('intent === "reassign"');
|
|
});
|
|
|
|
test("booking-page editor action guards admin permission + CSRF before parsing the form", () => {
|
|
const source = fs.readFileSync(path.join(appRoot, "modules/booking/routes/BookingPageEditor.server.ts"), "utf8");
|
|
const formDataAt = source.indexOf("await request.formData()");
|
|
expect(formDataAt).toBeGreaterThanOrEqual(0);
|
|
|
|
const permissionAt = source.indexOf("requireBookingPermission(ctx, BOOKING_PERMISSIONS.admin)", source.indexOf("bookingPageEditorAction"));
|
|
const csrfAt = source.indexOf("await validateCSRFToken(request)");
|
|
expect(permissionAt).toBeGreaterThanOrEqual(0);
|
|
expect(csrfAt).toBeGreaterThanOrEqual(0);
|
|
expect(permissionAt).toBeLessThan(formDataAt);
|
|
expect(csrfAt).toBeLessThan(formDataAt);
|
|
});
|
|
});
|